Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redisinsight 2.48 #171595

Merged
merged 2 commits into from Apr 19, 2024
Merged

redisinsight 2.48 #171595

merged 2 commits into from Apr 19, 2024

Conversation

7rulnik
Copy link
Contributor

@7rulnik 7rulnik commented Apr 17, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Right now installation fails:

❯ brew install --cask redisinsight
==> Downloading https://download.redisinsight.redis.com/latest/RedisInsight-mac-arm64.dmg
Already downloaded: /Users/v7rulnik/Library/Caches/Homebrew/downloads/ea999d2d5931d7024288aa13e24bfcc62f238c0470d5d89406b766525a6703f8--RedisInsight-mac-arm64.dmg
Warning: No checksum defined for cask 'redisinsight', skipping verification.
==> Installing Cask redisinsight
==> Purging files for version 2.46.0 of Cask redisinsight
Error: It seems the App source '/opt/homebrew/Caskroom/redisinsight/2.46.0/RedisInsight.app' is not there.

Looks like redis changed the app name recently:
image

Audit fails because for some reasons latest release stands for 2.46, but in reality latest is 2.48 https://github.com/RedisInsight/RedisInsight/releases

@7rulnik 7rulnik changed the title Fix redisinsight app name redisinsight 2.48 Apr 17, 2024
@krehel
Copy link
Member

krehel commented Apr 17, 2024

Audit fails because 2.48 is not marked as the latest release on GitHub, which the livecheck strategy is using. That release should be marked as the latest release if it is. Alternatively if :github_latest is not needed, that livecheck can be dropped.

That said, it does appear this is an Electron app, so there may be some additional enhancements. Let me look into this for a bit today.

@dalisoft
Copy link
Contributor

dalisoft commented Apr 19, 2024

@krehel Seems https://github.com/RedisInsight/RedisInsight/releases/latest is already v2.48, can you please trigger CI

@razvanazamfirei razvanazamfirei added the ci-requeue Triggers a CI re-run when applied. label Apr 19, 2024
@BrewTestBot BrewTestBot removed the ci-requeue Triggers a CI re-run when applied. label Apr 19, 2024
@krehel krehel merged commit 4a050d3 into Homebrew:master Apr 19, 2024
9 checks passed
@7rulnik 7rulnik deleted the fix-redisinsight branch April 21, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants