Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recipe for Darwin Font #174109

Merged
merged 8 commits into from
May 17, 2024
Merged

Add Recipe for Darwin Font #174109

merged 8 commits into from
May 17, 2024

Conversation

jaypmorgan
Copy link
Contributor

@jaypmorgan jaypmorgan commented May 17, 2024

"Darwin is a free and open-source ty­pe­fa­ce project aiming to develop a com­pre­hen­sive set of fonts intended for book and article writing, with a particular focus on aca­de­mic and scientific usage."

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added new cask missing description Cask is missing a description, please add one. labels May 17, 2024
Copy link
Contributor

@Aaron-212 Aaron-212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest some changes

Casks/font/font-d/font-darwin.rb Outdated Show resolved Hide resolved
Casks/font/font-d/font-darwin.rb Outdated Show resolved Hide resolved
Casks/font/font-d/font-darwin.rb Outdated Show resolved Hide resolved
Casks/font/font-d/font-darwin.rb Outdated Show resolved Hide resolved
@miccal miccal added the awaiting user reply Issue needs response from a user. label May 17, 2024
jaypmorgan and others added 4 commits May 17, 2024 13:46
Co-authored-by: Aaron Ruan <aaron212cn@outlook.com>
Co-authored-by: Aaron Ruan <aaron212cn@outlook.com>
Co-authored-by: Aaron Ruan <aaron212cn@outlook.com>
Co-authored-by: Aaron Ruan <aaron212cn@outlook.com>
@jaypmorgan jaypmorgan requested a review from Aaron-212 May 17, 2024 13:58
Copy link
Contributor

@Aaron-212 Aaron-212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't request me to review😂 I don't have access to approve PR

@jaypmorgan
Copy link
Contributor Author

Sorry, I thought you had the privilege! :-D

@BrewTestBot BrewTestBot removed the missing description Cask is missing a description, please add one. label May 17, 2024
@miccal miccal removed the awaiting user reply Issue needs response from a user. label May 17, 2024
@miccal miccal added the ready to merge PR can be merged once CI is green label May 17, 2024
@miccal miccal merged commit 31845b1 into Homebrew:master May 17, 2024
15 checks passed
@miccal
Copy link
Member

miccal commented May 17, 2024

Thank you @jaypmorgan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new cask ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants