-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wins app #174132
Merged
Merged
add wins app #174132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh yeah. all passed! 🎉 |
krehel
reviewed
May 17, 2024
krehel
reviewed
May 17, 2024
Thanks |
miccal
reviewed
May 17, 2024
Casks/w/wins.rb
Outdated
|
||
livecheck do | ||
url "https://wins.cool/" | ||
strategy :page_match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
strategy :page_match |
This can be removed, as it is the default strategy.
miccal
reviewed
May 17, 2024
Casks/w/wins.rb
Outdated
"~/Library/Application Support/cools.wins.main", | ||
"~/Library/Application Support/Wins", | ||
"~/Library/Caches/cools.wins.main", | ||
"~/Library/Caches/cools.wins.main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"~/Library/Caches/cools.wins.main", |
Duplicate line.
Co-authored-by: Justin Krehel <39449589+krehel@users.noreply.github.com> Co-authored-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
miccal
approved these changes
May 17, 2024
krehel
approved these changes
May 17, 2024
Thank you @EggsBlue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.