Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wins app #174132

Merged
merged 1 commit into from
May 17, 2024
Merged

add wins app #174132

merged 1 commit into from
May 17, 2024

Conversation

EggsBlue
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@EggsBlue
Copy link
Contributor Author

oh yeah.

all passed! 🎉

Casks/w/wins.rb Outdated Show resolved Hide resolved
Casks/w/wins.rb Outdated Show resolved Hide resolved
@EggsBlue
Copy link
Contributor Author

Thanks

Casks/w/wins.rb Outdated

livecheck do
url "https://wins.cool/"
strategy :page_match
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
strategy :page_match

This can be removed, as it is the default strategy.

Casks/w/wins.rb Outdated
"~/Library/Application Support/cools.wins.main",
"~/Library/Application Support/Wins",
"~/Library/Caches/cools.wins.main",
"~/Library/Caches/cools.wins.main",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"~/Library/Caches/cools.wins.main",

Duplicate line.

Co-authored-by: Justin Krehel <39449589+krehel@users.noreply.github.com>

Co-authored-by: Justin Krehel <39449589+krehel@users.noreply.github.com>
@miccal miccal added the ready to merge PR can be merged once CI is green label May 17, 2024
@miccal miccal merged commit fcb81ee into Homebrew:master May 17, 2024
11 checks passed
@miccal
Copy link
Member

miccal commented May 17, 2024

Thank you @EggsBlue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new cask ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants