Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blitz-gg 2.1.165 (new cask) #174573

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

PythonCoderAS
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

It seems that the cask existed but at some point they changed a bunch of the subdomain names, and was removed in #138248.

@PythonCoderAS PythonCoderAS changed the title blitzgg 2.1.165 (new cask) blitz 2.1.165 (new cask) May 22, 2024
Casks/b/blitz.rb Outdated Show resolved Hide resolved
Casks/b/blitz.rb Outdated Show resolved Hide resolved
@miccal
Copy link
Member

miccal commented May 23, 2024

Suggested changes based on the following:

Screenshot 2024-05-23 at 16 23 40

@miccal miccal added the awaiting user reply Issue needs response from a user. label May 23, 2024
@miccal miccal removed the awaiting user reply Issue needs response from a user. label May 23, 2024
@miccal
Copy link
Member

miccal commented May 23, 2024

audit for blitz: failed
 - possible duplicate, cask token conflicts with Homebrew core formula: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/b/blitz.rb

@miccal miccal added the awaiting maintainer feedback Issue needs response from a maintainer. label May 23, 2024
@p-linnane
Copy link
Member

Would be fine with blitz-gg.

blitz 2.1.165 (new cask)

Co-authored-by: Miccal Matthews <miccal.matthews@gmail.com>

Co-authored-by: Miccal Matthews <miccal.matthews@gmail.com>
@miccal miccal removed the awaiting maintainer feedback Issue needs response from a maintainer. label May 26, 2024
@miccal miccal changed the title blitz 2.1.165 (new cask) blitz-gg 2.1.165 (new cask) May 26, 2024
@p-linnane p-linnane merged commit 6e4cc17 into Homebrew:master May 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants