Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horos: add arm arch support #177520

Merged
merged 1 commit into from
Jul 3, 2024
Merged

horos: add arm arch support #177520

merged 1 commit into from
Jul 3, 2024

Conversation

khipp
Copy link
Contributor

@khipp khipp commented Jun 22, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the overall review to the cask maintainers but here's one small tweak to the livecheck block.

Casks/h/horos.rb Outdated Show resolved Hide resolved
@samford samford added the livecheck Issues or PRs related to livecheck label Jun 22, 2024
Casks/h/horos.rb Outdated Show resolved Hide resolved
Casks/h/horos.rb Outdated Show resolved Hide resolved
Casks/h/horos.rb Outdated Show resolved Hide resolved
Casks/h/horos.rb Outdated Show resolved Hide resolved
Casks/h/horos.rb Outdated Show resolved Hide resolved
Casks/h/horos.rb Show resolved Hide resolved
@p-linnane p-linnane merged commit f22c9ae into Homebrew:master Jul 3, 2024
9 checks passed
@khipp khipp deleted the update-horos branch July 3, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants