Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow third-party taps to include both casks and formulae. #177890

Closed

Conversation

reitermarkus
Copy link
Member

I have formulae and casks in my personal tap and I'm syncing the CI config from here, which is failing due to this workflow flagging formula files, so allow formula files in third party taps.

@SMillerDev
Copy link
Member

I don't think the cask repo should have formula code. But if we start using test bot it might be fine.

I once started work for that in Homebrew/homebrew-test-bot#1006

@reitermarkus
Copy link
Member Author

I think we can just move this into TapAuditor instead.

@p-linnane p-linnane requested a review from a team July 3, 2024 01:52
@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Jul 3, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason to merge this. I don't think the desire to sync this to third-party taps is a good reason to modify the code in this repository, sorry.

@bevanjkay bevanjkay closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip awaiting maintainer feedback Issue needs response from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants