Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-analytics-opt-out: remove livecheck #178748

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Jul 6, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

The livecheck strategy conflicts with the versioned url.

Related to #171006.

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label Jul 6, 2024
@khipp khipp force-pushed the update-google-analytics-opt-out branch from bc1efbc to 1d8a4bc Compare July 6, 2024 21:30
@chenrui333 chenrui333 added the livecheck Issues or PRs related to livecheck label Jul 7, 2024
@chenrui333 chenrui333 merged commit 1bd9f16 into Homebrew:master Jul 9, 2024
11 checks passed
@khipp khipp deleted the update-google-analytics-opt-out branch July 9, 2024 18:51
github-actions bot pushed a commit to MPLew-is/homebrew-vscodium that referenced this pull request Jul 9, 2024
…ogle-analytics-opt-out

google-analytics-opt-out: remove livecheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck missing zap Cask is missing a zap stanza, please add one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants