Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivacy 7.0.0,8 (new cask) #179949

Merged
merged 1 commit into from
Jul 18, 2024
Merged

ivacy 7.0.0,8 (new cask) #179949

merged 1 commit into from
Jul 18, 2024

Conversation

Zoobdude
Copy link
Contributor

Unfortunately I was unable to find any reference to any versions anywhere on the site and have had to use the extract_plist strategy.

Link to download - https://www.ivacy.com/download-vpn/vpn-for-mac/

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@khipp
Copy link
Member

khipp commented Jul 18, 2024

Thank you for your submission, @Zoobdude! I checked the homepage and application and could not find any version information either. However, the vendor seems to be working towards adding an update functionality:

For MAC users software auto-update feature is not supported yet so they’ll need to manually download and run the newer version. Make sure to trash old version preferences file when you download the latest version.

As we are currently making an effort to replace usages of the :extract_plist strategy in #171006, I would prefer to wait until that change has been made. Feel free to re-submit your PR then, and consider hosting the application in your own Tap in the meantime.

@khipp khipp closed this Jul 18, 2024
@bevanjkay
Copy link
Member

I think in the absence of any alternative, extract_plist is ok, that's what it's there for, but we should only use it if it's absolutely required.

@khipp khipp reopened this Jul 18, 2024
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with this otherwise. Thanks, @Zoobdude!

@khipp khipp merged commit f5079bc into Homebrew:master Jul 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants