Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mpv.rb which duplicates core formula mpv #20483

Merged
merged 1 commit into from Apr 11, 2016

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Apr 11, 2016

I'm bringing up #17447 again.

First, there's the duplication issue (see #15603).

Secondly and more importantly, there has been no official OS X build for the past three releases (and no sign for its resurgence in the future), so the cask is stuck on the now-roughly-half-a-year-old 0.14.0 while mpv as well as its core formula has moved on to 0.17.0. Keeping an increasingly outdated version in cask won't benefit anyone (one should assume that a user capable of installing Cask in the first place should be capable of running brew install mpv).

Also see discussion and pointers in #17447 for why mpv is actually a command line tool.

First, there's the duplication issue (see Homebrew#15603).

Secondly and more importantly, there has been no official OS X build for
the past three releases (and no sign for its resurgence in the future),
so the cask is stuck on the now-roughly-half-a-year-old 0.14.0 while mpv
as well as its core formula has moved on to 0.17.0. Keeping an
increasingly outdated version in cask won't benefit anyone (one should
assume that a user capable of installing Cask in the first place should
be capable of running `brew install mpv`).

Also see discussion and pointers in Homebrew#17447 for why mpv is actually a
command line tool.
@zmwangx
Copy link
Contributor Author

zmwangx commented Apr 11, 2016

See also mpv-player/mpv#2775. Apparently the "official" builds are one maintainer's personal endeavor (who couldn't seem to build a bundle that works on both El Cap and Yosemite since 0.15.0). Homebrew's official bottling system with multiple OS versions should be better.

@vitorgalvao
Copy link
Member

I strongly agree.

@adidalal Any objections? You were the one to initially suggest we take it slow with these.

@vitorgalvao vitorgalvao added the awaiting maintainer feedback Issue needs response from a maintainer. label Apr 11, 2016
@adidalal
Copy link
Contributor

Reasonable discussion, and in this case I'd also go with removal.

Still would like to take these on a case-by-case basis, though.

@adidalal adidalal merged commit 0ddc279 into Homebrew:master Apr 11, 2016
@vitorgalvao
Copy link
Member

Still would like to take these on a case-by-case basis, though.

No objections to that.

@zmwangx zmwangx deleted the remove-mpv branch April 11, 2016 22:03
@adidalal adidalal removed awaiting user reply Issue needs response from a user. awaiting maintainer feedback Issue needs response from a maintainer. labels Apr 12, 2016
chrismetcalf pushed a commit to chrismetcalf/homebrew-cask that referenced this pull request Apr 21, 2016
First, there's the duplication issue (see Homebrew#15603).

Secondly and more importantly, there has been no official OS X build for
the past three releases (and no sign for its resurgence in the future),
so the cask is stuck on the now-roughly-half-a-year-old 0.14.0 while mpv
as well as its core formula has moved on to 0.17.0. Keeping an
increasingly outdated version in cask won't benefit anyone (one should
assume that a user capable of installing Cask in the first place should
be capable of running `brew install mpv`).

Also see discussion and pointers in Homebrew#17447 for why mpv is actually a
command line tool.
@fanquake fanquake mentioned this pull request Aug 10, 2016
8 tasks
niksy added a commit to niksy/homebrew-pljoska that referenced this pull request Aug 15, 2016
@ivankovnatsky
Copy link

I don't know guys, I would keep mpv as a binary and ship it like this one: https://laboratory.stolendata.net/~djinn/mpv_osx/.

Me, I don't want any unneeded packages, like all the deps. I know the libs are included, still it is one package. I though that was the case. Maybe chromium should also be removed from casks and be building/shipped with all the deps, no?

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 1, 2016

  1. The binaries are crippled, and weren't even versioned until recently;
  2. Again, see Mac OS X release builds [was: tar.bz2] mpv-player/mpv#2775 for why app bundle is simply not how mpv was designed to work;
  3. If you really want the app bundle in binary form, you can do that in your own tap.

@ivankovnatsky
Copy link

@zmwangx ok. thanks.

@adidalal
Copy link
Contributor

adidalal commented Oct 1, 2016

@sevenfourk I use MplayerX now, if you want a alternative with a Cask.

Unofficial mpv osx builds are at https://laboratory.stolendata.net/~djinn/mpv_osx/ if you want binaries

@zmwangx
Copy link
Contributor Author

zmwangx commented Oct 1, 2016

FYI, MPlayerX is a GPL violation...

@adidalal
Copy link
Contributor

adidalal commented Oct 1, 2016

Just looked into it and MPlayerX is now bundling adware (though the Cask install isn't affected)....retracting my earlier recommendation

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants