New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mpv.rb which duplicates core formula mpv #20483
Conversation
First, there's the duplication issue (see Homebrew#15603). Secondly and more importantly, there has been no official OS X build for the past three releases (and no sign for its resurgence in the future), so the cask is stuck on the now-roughly-half-a-year-old 0.14.0 while mpv as well as its core formula has moved on to 0.17.0. Keeping an increasingly outdated version in cask won't benefit anyone (one should assume that a user capable of installing Cask in the first place should be capable of running `brew install mpv`). Also see discussion and pointers in Homebrew#17447 for why mpv is actually a command line tool.
See also mpv-player/mpv#2775. Apparently the "official" builds are one maintainer's personal endeavor (who couldn't seem to build a bundle that works on both El Cap and Yosemite since 0.15.0). Homebrew's official bottling system with multiple OS versions should be better. |
I strongly agree. @adidalal Any objections? You were the one to initially suggest we take it slow with these. |
Reasonable discussion, and in this case I'd also go with removal. Still would like to take these on a case-by-case basis, though. |
No objections to that. |
First, there's the duplication issue (see Homebrew#15603). Secondly and more importantly, there has been no official OS X build for the past three releases (and no sign for its resurgence in the future), so the cask is stuck on the now-roughly-half-a-year-old 0.14.0 while mpv as well as its core formula has moved on to 0.17.0. Keeping an increasingly outdated version in cask won't benefit anyone (one should assume that a user capable of installing Cask in the first place should be capable of running `brew install mpv`). Also see discussion and pointers in Homebrew#17447 for why mpv is actually a command line tool.
Removed in Cask with Homebrew/homebrew-cask#20483
I don't know guys, I would keep mpv as a binary and ship it like this one: https://laboratory.stolendata.net/~djinn/mpv_osx/. Me, I don't want any unneeded packages, like all the deps. I know the libs are included, still it is one package. I though that was the case. Maybe chromium should also be removed from casks and be building/shipped with all the deps, no? |
|
@zmwangx ok. thanks. |
Unofficial mpv osx builds are at |
FYI, MPlayerX is a GPL violation... |
Just looked into it and MPlayerX is now bundling adware (though the Cask install isn't affected)....retracting my earlier recommendation |
I'm bringing up #17447 again.
First, there's the duplication issue (see #15603).
Secondly and more importantly, there has been no official OS X build for the past three releases (and no sign for its resurgence in the future), so the cask is stuck on the now-roughly-half-a-year-old 0.14.0 while mpv as well as its core formula has moved on to 0.17.0. Keeping an increasingly outdated version in cask won't benefit anyone (one should assume that a user capable of installing Cask in the first place should be capable of running
brew install mpv
).Also see discussion and pointers in #17447 for why mpv is actually a command line tool.