Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Caskroom location, see #475 #2066

Merged
merged 7 commits into from Dec 14, 2013
Merged

Configurable Caskroom location, see #475 #2066

merged 7 commits into from Dec 14, 2013

Conversation

halo
Copy link

@halo halo commented Dec 12, 2013

No description provided.

@mmzoo mmzoo mentioned this pull request Dec 12, 2013
@nanoxd
Copy link
Contributor

nanoxd commented Dec 12, 2013

@halo Can you write a test for this change?

@halo
Copy link
Author

halo commented Dec 12, 2013

Sorry, I simply forgot. I added the test now, it's basically the same as for the --appdir flag.

Finished tests in 667.799174s, 1.5693 tests/s, 4.4579 assertions/s.
1048 tests, 2977 assertions, 0 failures, 0 errors, 0 skips

@passcod
Copy link
Contributor

passcod commented Dec 13, 2013

It would imo be better to use a new wiki page for option descriptions, or a section on an existing one. Additionally, why would that option be given more visibility than the others, by having it as example? Is it really going to be the one most people look for? Do we even have data on this? Examples need not be random, they can have an agenda, make sure it's not wasted on something few people will engage with, maybe?

@halo
Copy link
Author

halo commented Dec 13, 2013

Ah, good points good points. I will come up with something.

@halo
Copy link
Author

halo commented Dec 14, 2013

What do you think? You can see the results here. I thought about adding a wiki page, but I think it's clearer to have everything at your fingertips in the very same revision control.

@phinze
Copy link
Contributor

phinze commented Dec 14, 2013

This is great @halo - thanks for you work on this! Merging now.

phinze added a commit that referenced this pull request Dec 14, 2013
Configurable Caskroom location, see #475
@phinze phinze merged commit 4bfc09e into Homebrew:master Dec 14, 2013
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants