Set rpath on dotnet cask's crypto lib to fix install failure #23846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this currently has a merge conflict, which is due to previous fixes to this package last night. Those fixes are incorrect IMO and lead to a potentially broken system due to https://langui.sh/2015/07/24/osx-clang-include-lib-search-paths/ |
|
Closing due to comments on https://github.com/dotnet/cli/issues/3964. I misunderstood the impact of the linking issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}left no offenses.This fixes https://github.com/dotnet/cli/issues/3964 properly
Note: I did not make the
/usr/local/opt/openssl/libinterrogate brew to find the correct location for non/usr/localinstalls as I was not sure how to do this in the cask. It should be"$(brew --prefix openssl)/lib. I welcome a fix for this prior to merge.