Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kontena-cli 1.1.1 #30000

Closed
wants to merge 2 commits into from
Closed

Add kontena-cli 1.1.1 #30000

wants to merge 2 commits into from

Conversation

kke
Copy link

@kke kke commented Feb 10, 2017

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
    • The cask is named kontena-cli as it only installs the CLI part of the stack, which is what most users want on their local machine as the rest of it will usually run on servers somewhere. In the future there may be installers for the server or agent components.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

(Fixes kontena/kontena#1825)

@vitorgalvao
Copy link
Member

This seems to be a CLI-only open-source tool. Please submit it first to Homebrew/core and only if they don’t accept it, submit here (linking back to the pull request where it was refused).

This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

version '1.1.1'
sha256 'a764f33f7b87ddbfcb844d09180956519c049b8b54c18967020741f17c39de96'

# github.com was verified as official when first introduced to the cask
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment needs to uniquely identify app or vendor (see the screencat example). The URL should be github.com/kontena/kontena.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fixed in the fork but it's not updating here as the PR is closed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the comment after closing, overlapped with Vitor's assessment, which makes mine null and void anyway.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew cask install kontena-cli
3 participants