-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding justgo 1.0.1 #30269
Adding justgo 1.0.1 #30269
Conversation
name 'justgo' | ||
homepage 'https://github.com/inadarei/justgo' | ||
|
||
app 'justgo' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an app
.
This seems to be a CLI-only open-source tool. Please submit it first to Homebrew/core and only if they don’t accept it, submit here (linking back to the pull request where it was refused). This policy is documented in faq/rejected_casks:
|
@vitorgalvao thank you for such prompt response. This is my first brew submission so I may not understand how to properly do it, but when I read instructions at homebrew/core it explicitely said they do not like binary submissions and any binary submission should be directed to Cask? What I am submitting is a Go CLI tool and it's important the installation to be binary / not require pre-existing Go environment (otherwise a Can you please clarify why a binary submission is redirected to core? Thanks |
Why can’t this be built from source? That’s the point. Unfortunately, I just noticed neither HB nor HBC will accept this. You’re self-submitting a tool with too few stars. We don’t accept those to keep the repos manageable with software other people will actually use. |
@vitorgalvao it can be built from source but that defeats the purpose. The only reason anybody would install a Go package with brew is to download a binary (and not have to install Go environment). If somebody already has a working Go environment, or is willing to install one, then |
If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}
worked successfully.brew cask uninstall {{cask_file}}
worked successfully.