Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding justgo 1.0.1 #30269

Closed
wants to merge 3 commits into from
Closed

Adding justgo 1.0.1 #30269

wants to merge 3 commits into from

Conversation

inadarei
Copy link

@inadarei inadarei commented Feb 20, 2017

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • [x ] Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

name 'justgo'
homepage 'https://github.com/inadarei/justgo'

app 'justgo'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an app.

@vitorgalvao
Copy link
Member

This seems to be a CLI-only open-source tool. Please submit it first to Homebrew/core and only if they don’t accept it, submit here (linking back to the pull request where it was refused).

This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

@inadarei
Copy link
Author

@vitorgalvao thank you for such prompt response. This is my first brew submission so I may not understand how to properly do it, but when I read instructions at homebrew/core it explicitely said they do not like binary submissions and any binary submission should be directed to Cask?

What I am submitting is a Go CLI tool and it's important the installation to be binary / not require pre-existing Go environment (otherwise a go get is more than sufficient).

Can you please clarify why a binary submission is redirected to core? Thanks

@vitorgalvao
Copy link
Member

Why can’t this be built from source? That’s the point.

Unfortunately, I just noticed neither HB nor HBC will accept this. You’re self-submitting a tool with too few stars. We don’t accept those to keep the repos manageable with software other people will actually use.

@inadarei
Copy link
Author

@vitorgalvao it can be built from source but that defeats the purpose. The only reason anybody would install a Go package with brew is to download a binary (and not have to install Go environment). If somebody already has a working Go environment, or is willing to install one, then go get <githuburl> is both simpler and easier.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants