Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webbreaker (new cask) #41690

Closed
wants to merge 1 commit into from
Closed

webbreaker (new cask) #41690

wants to merge 1 commit into from

Conversation

jimnelson2
Copy link

New cask for webbreaker, version 2.0.04

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

New cask for webbreaker, version 2.0.04
@commitay
Copy link
Contributor

commitay commented Dec 6, 2017

Rejected Casks
The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

This app is a wrapper for a CLI tool.

@commitay commitay closed this Dec 6, 2017
@jimnelson2
Copy link
Author

Sounds good, thanks. We tried this Homebrew/homebrew-core#21326, but were told we should build from source...which led me to cask since I didn't have a readily available build script to inject. I don't think I have a preference for one path over the other, just want to do what makes the most sense within the community.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants