Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-machine-driver-hyperkit v0.24.1 #43035

Closed
wants to merge 1 commit into from
Closed

Add docker-machine-driver-hyperkit v0.24.1 #43035

wants to merge 1 commit into from

Conversation

or1can
Copy link

@or1can or1can commented Jan 20, 2018

Adds the HyperKit Docker Machine driver, from the Minikube project. It
requires running as root, so sets root ownership during install and has
a caveat that it must be given setuid permission, as per the offical
installation instructions.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

Adds the HyperKit Docker Machine driver, from the Minikube project. It
requires running as root, so sets root ownership during install and has
a caveat that it must be given setuid permission, as per the offical
installation instructions.
@commitay
Copy link
Contributor

Rejected Casks
The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).


@commitay commitay closed this Jan 20, 2018
@or1can
Copy link
Author

or1can commented Jan 21, 2018

No worries. Will try Hombrew/core. Submitted here because minikube (which this depends on) is a cask and not in Hombrew/core.

@tnir
Copy link

tnir commented Mar 7, 2018

@or1can Did you try to submit this to Homebrew/core?

I just found previous PRs to core were not merged 😭 :

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants