-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stand from 1.0.4 to 2.0 #80965
Update stand from 1.0.4 to 2.0 #80965
Conversation
@vitorgalvao they ask for money via gumroad on their product site now. i don't know if this was the case previously. while it can be downloaded for free when selecting 0$ as an option, i am not sure if circumventing their paywall is the right thing here |
@core-code FWIW I hate it when companies exhibit this type of behavior. 🤮 |
isn't that unsafe because 'f001.backblazeb2.com/file/stand-app-fake' would also match? |
That’s a bloody good point. And since that’s the standard, it also means we’ll have to correct every cask that uses this comment (2038)! I’ll make a script later. |
Their pinned tweet makes me think so (emphasis added):
On the website, they mention (emphasis added):
And since:
I’d say this might be OK. By accepting $0, they’re essentially asking for donations. |
sounds good, i agree! maybe a 'caveats' would be nice in these cases too, although i realise that we try to minimise that. |
i really thought the standard was the other way round exactly for this reason. unless the implementation adds the trailing slash automatically? |
No, the implementation uses what we give it. That’s necessary for cases when a version is part of the comment, since those don’t take the interpolation. Somewhere in the beginning we decided on that and never revisited, I guess (I no longer remember). |
I’m fixing the comments now, and think I may remember why we decided on not having the trailing slash at the time. A lot of these cases (perhaps the majority) only need the differing domain (no subdirectory) in the comment. Seeing as those end in a TLD, they don’t pose a problem (or should I say didn’t, since TLD names are now the Wild West). This check is in I do remember writing that the comment should contain “the smallest possible portion of the URL that uniquely identifies the app or vendor”, back when were still under the Caskroom org, but by that time it’s likely we didn’t reconsider the stylistic part of the choice. |
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
left no offenses.