Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stand from 1.0.4 to 2.0 #80965

Merged
merged 3 commits into from Apr 20, 2020
Merged

Update stand from 1.0.4 to 2.0 #80965

merged 3 commits into from Apr 20, 2020

Conversation

core-code
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.
  • The commit message includes the cask’s name and version.

@core-code
Copy link
Contributor Author

@vitorgalvao they ask for money via gumroad on their product site now. i don't know if this was the case previously. while it can be downloaded for free when selecting 0$ as an option, i am not sure if circumventing their paywall is the right thing here

@ran-dall
Copy link
Contributor

ran-dall commented Apr 19, 2020

@core-code FWIW I hate it when companies exhibit this type of behavior. 🤮

@core-code
Copy link
Contributor Author


   # f001.backblazeb2.com/file/stand-app/ was verified as official when first introduced to the cask
   # f001.backblazeb2.com/file/stand-app was verified as official when first introduced to the cask

isn't that unsafe because 'f001.backblazeb2.com/file/stand-app-fake' would also match?

@vitorgalvao
Copy link
Member

isn't that unsafe because 'f001.backblazeb2.com/file/stand-app-fake' would also match?

That’s a bloody good point. And since that’s the standard, it also means we’ll have to correct every cask that uses this comment (2038)!

I’ll make a script later.

@vitorgalvao
Copy link
Member

they ask for money via gumroad on their product site now. i don't know if this was the case previously.

Their pinned tweet makes me think so (emphasis added):

(…) a new version of Stand is available! Stand 2 (…) Existing users can check for updates in app, and it's also available at the same 'pay what you like' price point (…)

On the website, they mention (emphasis added):

We built Stand in our spare time, and if you’d like to download it, you’re welcome to pay whatever you think it’s worth

And since:

our users are expected to have reasonable knowledge about the apps they’re installing through us before doing so.

I’d say this might be OK. By accepting $0, they’re essentially asking for donations.

@core-code
Copy link
Contributor Author

sounds good, i agree! maybe a 'caveats' would be nice in these cases too, although i realise that we try to minimise that.

@core-code
Copy link
Contributor Author

That’s a bloody good point. And since that’s the standard, it also means we’ll have to correct every cask that uses this comment (2038)!

i really thought the standard was the other way round exactly for this reason. unless the implementation adds the trailing slash automatically?

@vitorgalvao
Copy link
Member

No, the implementation uses what we give it. That’s necessary for cases when a version is part of the comment, since those don’t take the interpolation.

Somewhere in the beginning we decided on that and never revisited, I guess (I no longer remember).

@vitorgalvao vitorgalvao reopened this Apr 20, 2020
@vitorgalvao vitorgalvao merged commit a72f91b into Homebrew:master Apr 20, 2020
@vitorgalvao
Copy link
Member

I’m fixing the comments now, and think I may remember why we decided on not having the trailing slash at the time.

A lot of these cases (perhaps the majority) only need the differing domain (no subdirectory) in the comment. Seeing as those end in a TLD, they don’t pose a problem (or should I say didn’t, since TLD names are now the Wild West). This check is in style, not audit, so we may have decided that all else being equal, we’d go for what looks best.

I do remember writing that the comment should contain “the smallest possible portion of the URL that uniquely identifies the app or vendor”, back when were still under the Caskroom org, but by that time it’s likely we didn’t reconsider the stylistic part of the choice.

@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@core-code core-code deleted the cask_repair_update-stand branch November 23, 2020 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants