Add flutter SDK v1.20.1 #87344
Add flutter SDK v1.20.1 #87344
Conversation
Casks/flutter.rb
Outdated
| conflicts_with cask: "dart" | ||
| depends_on macos: ">= :catalina" | ||
|
|
||
| app "flutter" |
There was a problem hiding this comment.
There is no app for this, only a binary, correct?
There was a problem hiding this comment.
It's a full sdk so it includes a few binaries (main one being flutter), sources, examples ... so I used app to expose the whole set in the Applications folder. Do you have any better suggestion ?
|
Does this not also require the Android SDK, Android Studio, CocoaPods and a full install of Xcode to be functional? |
@miccal They are not part of the system requirements of the SDK (see the official docs). |
True, but won't |
|
Please also note that the addition of and hence it may be wise to wait until @vitorgalvao has had a chance to review and comment on this PR before making any changes. |
Casks/flutter.rb
Outdated
| app "flutter" | ||
| binary "flutter/bin/flutter" | ||
|
|
||
| uninstall rmdir: [ |
There was a problem hiding this comment.
rmdir is for empty directories. You want delete. But this can be removed, this would already be done automatically.
Casks/flutter.rb
Outdated
| "#{appdir}/flutter", | ||
| ] | ||
|
|
||
| caveats <<~EOS |
There was a problem hiding this comment.
Remove this. If we had this caveat for every app that needed it, half the casks would have it.
There was a problem hiding this comment.
Ok, I wasn't sure but I couldn't find anything regarding this in the docs, I may have missed it though. Otherwise it might be worth a note ?
| sha256 "a6364d48455bd7eb749bcbd0b7c71b985bccb0149ea0dd95c6bef3bbb2e9f91b" | ||
|
|
||
| # storage.googleapis.com/flutter_infra/releases/stable/macos/ was verified as official when first introduced to the cask | ||
| url "https://storage.googleapis.com/flutter_infra/releases/stable/macos/flutter_macos_#{version}-stable.zip" |
There was a problem hiding this comment.
How do we get here from the homepage?
There was a problem hiding this comment.
flutter.dev > Get Started > macOS > Get the Flutter SDK
Thank you for remembering those things! This name did ring a bell and I checked. The last time this was discussed, good arguments were made for this as a cask and I gave the thumbs up but the user ended up not submitting. |
|
@vitorgalvao CI is failing now. Is |
|
@jota3 the |
| depends_on macos: ">= :catalina" | ||
|
|
||
| suite "flutter" | ||
| binary "flutter/bin/flutter" |
There was a problem hiding this comment.
| binary "flutter/bin/flutter" | |
| binary "flutter/bin/dart" | |
| binary "flutter/bin/flutter" |
| conflicts_with cask: "dart" | ||
| depends_on macos: ">= :catalina" | ||
|
|
||
| suite "flutter" |
There was a problem hiding this comment.
| suite "flutter" |
I don't think there is a point in installing SDK in the Applications folder. It's just a Git repo without any GUI applications. Probably should be deleted.
|
An updated version of the PR: #87690 |
|
Hello, any updates on this PR? When it can be merged? |
|
Closing in favour of #87690. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}reports no offenses.Additionally, if adding a new cask:
brew cask audit --new-cask {{cask_file}}worked successfully.brew cask install {{cask_file}}worked successfully.brew cask uninstall {{cask_file}}worked successfully.