Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imgur.rb: add zap stanza #88545

Merged
merged 2 commits into from Sep 1, 2020
Merged

Update imgur.rb: add zap stanza #88545

merged 2 commits into from Sep 1, 2020

Conversation

Akylzhan
Copy link
Contributor

@Akylzhan Akylzhan commented Sep 1, 2020

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask audit --new-cask {{cask_file}} worked successfully.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.

@Akylzhan Akylzhan mentioned this pull request Sep 1, 2020
@@ -7,4 +7,6 @@
homepage "https://github.com/zbuc/imgurBar"

app "imgur.app"

zap trash: "~/Library/Caches/com.zbuc.imgur"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a single entry, we can use a string instead.

@vitorgalvao vitorgalvao merged commit 54b1d8d into Homebrew:master Sep 1, 2020
@Akylzhan Akylzhan deleted the patch-1 branch September 2, 2020 04:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants