Improve docs for desc stanza.
#89483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorgalvao
previously requested changes
Sep 17, 2020
vitorgalvao
dismissed
their stale review
Meant it to be individual comments
|
From #87436, we should also add:
|
reitermarkus
force-pushed
the
desc-docs
branch
2 times, most recently
from
35762e8
to
7828ce9
Compare
reitermarkus
force-pushed
the
desc-docs
branch
from
7828ce9
to
ded75f4
Compare
vitorgalvao
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some Dos and Don'ts.