New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inital upload (version 2.1.0) #90486

Closed

smittytone wants to merge 1 commit into Homebrew:master from smittytone:pdfmaker-210

smittytone commented Oct 7, 2020

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

[*] brew cask audit --download {{cask_file}} is error-free.
brew cask style --fix {{cask_file}} reports no offenses. COULDN'T DO THIS: too many gem install errors (I'm on BIg Sur)
[*] There are no open pull requests for the same update.
[*] The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

[*] Named the cask according to the token reference.
[*] brew cask audit --new-cask {{cask_file}} worked successfully.
[*] brew cask install {{cask_file}} worked successfully.
[*] brew cask uninstall {{cask_file}} worked successfully.
[*] Checked the cask was not already refused.
[*] Checked the cask is submitted to the correct repo.


          Inital upload (version 2.1.0)

39fb95d

smittytone closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment