Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zap stanza for jenkins-menu #97196

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Added zap stanza for jenkins-menu #97196

merged 1 commit into from
Jan 7, 2021

Conversation

adithyasunil26
Copy link
Contributor

@adithyasunil26 adithyasunil26 commented Jan 1, 2021

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@vitorgalvao vitorgalvao added the ci-requeue Triggers a CI re-run when applied. label Jan 4, 2021
@BrewTestBot BrewTestBot removed the ci-requeue Triggers a CI re-run when applied. label Jan 4, 2021
@miccal miccal added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jan 6, 2021
@BrewTestBot BrewTestBot merged commit 0a4b2f8 into Homebrew:master Jan 7, 2021
@adithyasunil26 adithyasunil26 deleted the jenkins-menu-zap branch January 7, 2021 09:28
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants