Skip to content

Commit

Permalink
borgbackup: do not depend on FUSE
Browse files Browse the repository at this point in the history 
Closes #65603.

Signed-off-by: FX Coudert <fxcoudert@gmail.com>
  • Loading branch information
@fxcoudert
fxcoudert committed Nov 24, 2020
1 parent 137a255 commit 89785cf
Showing 1 changed file with 1 addition and 16 deletions.
17 changes: 1 addition & 16 deletions Formula/borgbackup.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class Borgbackup < Formula
url "https://github.com/borgbackup/borg/releases/download/1.1.14/borgbackup-1.1.14.tar.gz"
sha256 "7dbb0747cc948673f695cd6de284af215f810fed2eb2a615ef26ddc7c691edba"
license "BSD-3-Clause"
revision 1
revision 2

livecheck do
url "https://github.com/borgbackup/borg/releases/latest"
Expand All @@ -20,32 +20,17 @@ class Borgbackup < Formula
sha256 "572afe4f34d36ae32c0ec48da8d4a2e9cc59b4ad891f884e5a1efe48e69c478c" => :high_sierra
end

deprecate! because: "requires FUSE"

depends_on osxfuse: :build
depends_on "pkg-config" => :build
depends_on "libb2"
depends_on "lz4"
depends_on "openssl@1.1"
depends_on "python@3.9"
depends_on "zstd"

resource "llfuse" do
url "https://files.pythonhosted.org/packages/8f/73/d35aaf5f650250756b40c1e718ee6a2d552700729476dee24c9837608e1b/llfuse-1.3.8.tar.gz"
sha256 "b9b573108a840fbaa5c8f037160cc541f21b8cbdc15c5c8a39d5ac8c1b6c4cbc"
end

def install
virtualenv_install_with_resources
end

def caveats
<<~EOS
To use `borg mount`, install osxfuse with Homebrew Cask:
brew cask install osxfuse
EOS
end

test do
# Create a repo and archive, then test extraction.
cp test_fixtures("test.pdf"), testpath
Expand Down

6 comments on commit 89785cf

@sunknudsen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fxcoudert. This commit broke borg mount support. See borgbackup/borg#5522. Any workarounds?

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that command needs fuse to function and homebrew doesn't ship fuse anymore because it's no longer open source.

@sunknudsen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMillerDev Thanks for the follow-up... I understand... do you know how to install llfuse on macOS? I will likely not be the only person looking for a workaround.

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way, there is only osxfuse and that became closed source last year.

@sunknudsen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I am missing something. FUSE for macOS can be installed via https://github.com/osxfuse/osxfuse/releases/latest right? The part I am missing is how to install llfuse. That being said, the assumption that I am just missing a way to install llfuse might be naive.

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llfuse is only needed if you have FUSE. And homebrew doesn't ship anything with FUSE functions enabled anymore because it's no longer open source.

Please sign in to comment.