Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing gst-plugins-bad does not find corevideomemory.h #1006

Closed
seppestas opened this issue May 9, 2016 · 5 comments
Closed

Installing gst-plugins-bad does not find corevideomemory.h #1006

seppestas opened this issue May 9, 2016 · 5 comments

Comments

@seppestas
Copy link

seppestas commented May 9, 2016 •
edited

When installing gst-plugins-bad with the with-applemedia flag, building fails (but installation completes) with the following error:

plugin.m:25:10: fatal error: 'corevideomemory.h' file not found

This seems to be caused by gst-plugins-bad-1.8.1.tar.xz not containing said corevideomemory.h file. The file is however present in the gst-plugins-bad git repo.

I know this is an issue with the package, not with Homebrew, but having this issue should at least create some visibility for people encountering the same error.

Reported in Gnome's Bugzilla as Bug 766163
@MikeMcQuaid
Copy link
Member

Nice detective work. In the short-term we could make resource containing a reference to this file in the Git repository and install that? Could you try and open a pull request? This document should help and I'm happy to walk you through anything else.

Thanks!

@UniqMartin UniqMartin added the needs response Needs a response from the issue/PR author label May 10, 2016
@ilovezfs ilovezfs mentioned this issue May 11, 2016
Closed
@ilovezfs
Copy link
Contributor

@MikeMcQuaid @Bitbored I opened a pull request fixing this here: #1069

@ilovezfs ilovezfs removed the needs response Needs a response from the issue/PR author label May 11, 2016
ilovezfs added a commit to ilovezfs/homebrew-core that referenced this issue May 12, 2016
@ilovezfs
gst-plugins-bad: fix applemedia support
1c810b4 
- add resources for the two missing headers to fix applemedia
- always compile with applemedia unless <= Mavericks

Since a fix has already been merged upstream, the two new resource
blocks should be removed when >1.8.1 is released.

https://bugzilla.gnome.org/show_bug.cgi?id=766163
GStreamer/gst-plugins-bad@4348748

Closes Homebrew#1006.
@ilovezfs
Copy link
Contributor

@Bitbored this is now fixed if you brew update. Also, the option has been removed and the feature set to be always enabled (except on Mavericks). That means you don't need to build from source because the binary bottles now have the feature.

@seppestas
Copy link
Author

Great, thanks!

@ilovezfs
Copy link
Contributor

@Bitbored You're welcome. Thanks for reporting this!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gst-plugins-bad: fix applemedia ilovezfs/homebrew-core
4 participants
@MikeMcQuaid @seppestas @ilovezfs @UniqMartin