Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottles (for MacVim) are built against the latest minor macOS versions (12.6) instead of major (12.0) #111693

Closed
2 tasks done
ychin opened this issue Sep 26, 2022 · 0 comments
Closed
2 tasks done
Labels
bug Reproducible Homebrew/homebrew-core bug outdated PR was locked due to age

Comments

@ychin
Copy link
Contributor

ychin commented Sep 26, 2022

brew gist-logs <formula> link OR brew config AND brew doctor output

➜ ychin ~/Dev/macvim% brew config
HOMEBREW_VERSION: 3.6.2
ORIGIN: https://github.com/Homebrew/brew
HEAD: b8b195cc64a29595797651720ebb2ea09affb682
Last commit: 7 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 012e1419fae80bcf83be22be9fd64091ebef333e
Core tap last commit: 7 days ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.YPjlI3mo8P/org.macosforge.xquartz:0
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 2.6.8 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 14.0.0 build 1400
Git: 2.37.0 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.79.1 => /usr/bin/curl
macOS: 12.5.1-arm64
CLT: 12.5.0.22.9
Xcode: 14.0
Rosetta 2: false

Verification

  • I ran brew update and am still able to reproduce my issue.
  • I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?

I am trying to launch MacVim after doing brew update macvim.

What happened (include all command output)?

MacVim doesn't launch, because I haven't updated to macOS 12.6 yet (I will do so shortly, but I'm currently on 12.5). Instead, I see this:

➜ ychin ~/Dev/macvim% open -n /opt/homebrew/Cellar/macvim/9.0.472/MacVim.app
The application cannot be opened for an unexpected reason, error=Error Domain=NSOSStatusErrorDomain Code=-10825 "kLSIncompatibleSystemVersionErr: The app cannot run on the current OS version" UserInfo={_LSLine=3863, _LSFunction=_LSOpenStuffCallLocal}

You can see that the bottle is built with 12.3 SDK, and requires minimum of 12.6:

➜ ychin ~/Dev/macvim% otool -l /opt/homebrew/Cellar/macvim/9.0.472/MacVim.app/Contents/MacOS/MacVim | grep "sdk\|minos"
    minos 12.6
      sdk 12.3

Note: this issue was opened because of this comment: macvim-dev/macvim#1289 (comment)

What did you expect to happen?

Homebrew-installed apps should work in all the supported macOS versions, and that should include 12.5. When building bottles, it should set the environmental variable MACOSX_DEPLOYMENT_TARGET explicitly to 12.0 when building bottles for macOS 12.0 Big Sur (and similarly for 11.0, etc). If you don't set that, Xcode will set it to the build system's OS, which would be 12.6 in this case.

To be specific, the output of otool should say minos 12.0.

I don't remember if this was ever an issue before when macOS's major version was always "10", and minor version was the actual important number (e.g. 10.14 and 10.15 were two separate yearly releases). I feel like because Apple made major versions actually represent the OS release now, they changed the behavior for Xcode to automatically set the target minimum OS to the minor version as well, but I'm not sure.

Step-by-step reproduction instructions (by running brew commands)

brew install macvim
open -n /opt/homebrew/Cellar/macvim/9.0.472/MacVim.app # Need to be running at 12.5 or below.
@ychin ychin added the bug Reproducible Homebrew/homebrew-core bug label Sep 26, 2022
@ychin ychin changed the title Bottles (for MacVim) are built with the latest minor macOS versions (12.6) instead of major (12.0) Bottles (for MacVim) are built against the latest minor macOS versions (12.6) instead of major (12.0) Sep 26, 2022
carlocab added a commit to carlocab/homebrew-core that referenced this issue Sep 26, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/homebrew-core bug outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant