Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Ventura bottling issues for top-usage formulas #116910

Closed
22 of 28 tasks
fxcoudert opened this issue Nov 29, 2022 · 5 comments
Closed
22 of 28 tasks

Tracking Ventura bottling issues for top-usage formulas #116910

fxcoudert opened this issue Nov 29, 2022 · 5 comments
Labels
13-arm64 Ventura arm64 is specifically affected 13 Ventura is specifically affected outdated PR was locked due to age ventura-bottling

Comments

@fxcoudert
Copy link
Member

fxcoudert commented Nov 29, 2022

The idea of this issue is to track and solve the build issues for macOS Ventura on our most used formulas. We already have an issue where all bottling failures are reported (#113717), this one is to keep an eye on the most important formulas (top 1500 in analytics). This top post can be edited with a short summary of current status, while our efforts and discussion of each formula can take place below.


Fail on both ARM and Intel

Fail on ARM only

Fail on Intel only

@fxcoudert fxcoudert added 13 Ventura is specifically affected 13-arm64 Ventura arm64 is specifically affected labels Nov 29, 2022
@cho-m
Copy link
Member

cho-m commented Nov 30, 2022

Updated list with some upstream issues and related Homebrew PRs. Additional comments:

  • octant and vault probably need node downgrade. EDIT: octant actually needs npm downgrade
  • pyqt@5 inreplace may need to match sip python version
  • hashcat seems to build even though ephemeral ARM doesn't have OpenCL support. If the resulting bottle does work on local machines, could just skip the test.

@cho-m
Copy link
Member

cho-m commented Nov 30, 2022

  • swiftgen - Xcode version requirement ~> 13.0 means it can only build with Xcode 13. May be intentional to avoid major version changes? One option is to just modify Rakefile logic to allow Xcode 14+. Otherwise, this formula will only work on 1-2 versions of macOS at a time.
  • volk - trying to bottle again as failure was due to a missing dependency (maybe cpu_features). It looks like everything is bottled now.
  • xapian - should be able to bottle now.
  • bazel - seems like an x86_64 binary is used at some point so may not work without Rosetta. Could be better on development releases (v6 / v7) as there are some commits relating to adding universal binaries, but might still be a problem as upstream issue is open.

@chenrui333
Copy link
Member

@cho-m
Copy link
Member

cho-m commented Dec 12, 2022

ncdu may be blocked until new release as it currently needs zig 0.9 to build but support for Ventura was added in zig 0.10. Could try applying commits from upstream's zig-0.10 branch but upstream issue mentions there is noticeable performance degradation.

EDIT: actually we are using -Drelease-fast=true so we might not hit performance issue seen with ReleaseSafe build.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jan 18, 2023
@fxcoudert fxcoudert removed the stale No recent activity label Jan 18, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
13-arm64 Ventura arm64 is specifically affected 13 Ventura is specifically affected outdated PR was locked due to age ventura-bottling
Projects
None yet
Development

No branches or pull requests

3 participants