Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: patch for Ventura #117052

Closed
wants to merge 1 commit into from
Closed

mono: patch for Ventura #117052

wants to merge 1 commit into from

Conversation

fxcoudert
Copy link
Member

Mono build issue on Ventura reported at mono/mono#21567
The patch is adapted from dotnet: dotnet/runtime#76433

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Dec 1, 2022
@fxcoudert
Copy link
Member Author

Build failing on ARM Ventura, in fsharp:

==> ./build.sh --configuration Release
/private/tmp/mono--fsharp-20221201-7573-1rmtltd/.dotnet/dotnet-install.sh: line 594: wget: command not found
/private/tmp/mono--fsharp-20221201-7573-1rmtltd/.dotnet/dotnet-install.sh: line 594: wget: command not found
dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1.405/dotnet-sdk-3.1.405-osx-x64.tar.gz
dotnet-install: Extracting zip from https://dotnetcli.azureedge.net/dotnet/Sdk/3.1.405/dotnet-sdk-3.1.405-osx-x64.tar.gz
dotnet-install: Adding to current process PATH: `/private/tmp/mono--fsharp-20221201-7573-1rmtltd/.dotnet`. Note: This change will be visible only when sourcing script.
dotnet-install: Installation finished successfully.
FSharp.sln:
/private/tmp/mono--fsharp-20221201-7573-1rmtltd/eng/common/tools.sh: line 447: /private/tmp/mono--fsharp-20221201-7573-1rmtltd/.dotnet/dotnet: Bad CPU type in executable
Build failed (exit code '126').
Error preparing build (exit code '126').

Maybe it passed on previous CI versions because they have Rosetta :(

@Bo98
Copy link
Member

Bo98 commented Dec 1, 2022

Yeah needs at least .NET 6. (Not entirely sure why it's using 3.1 - I would have expected it to be using .NET 5 given it's F# 5 but it doesn't really matter since neither would work.) So I guess we need F# 6: mono/mono#21312.

I guess patching it to build on .NET 6 could be an alternative, though perhaps a little risky.

@cho-m
Copy link
Member

cho-m commented Dec 1, 2022

Could also temporarily disable F# on ARM. mono formula on ARM is already pared down as I had disabled MSBuild when working on bottling Mono for ARM -- #111080.

MSBuild support is still pending on uplift to v17 and F# seems to be in a similar situation of waiting on a new version.

@fxcoudert
Copy link
Member Author

@p-linnane why do not merge? I intend to merge this, it brings build on Intel Ventura, which is better than nothing.

@p-linnane
Copy link
Member

Tagged it due to the feedback from @Bo98 & @cho-m.

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@fxcoudert fxcoudert deleted the mono branch December 4, 2022 17:22
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue ventura-bottling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants