Building ffmpeg, ffmbc, or libav makes error with faac 1.29.9

[s172262]

See #20315 .
reported at https://trac.ffmpeg.org/ticket/6809

All errors caused from libavcodec.

libavcodec/libfaac.c:87:15: error: no member named 'allowMidside' in 'struct faacEncConfiguration'
    faac_cfg->allowMidside = 1;
    ~~~~~~~~  ^
1 error generated.
make: *** [libavcodec/libfaac.o] Error 1
make: *** Waiting for unfinished jobs....

"allowMidside" was removed from include/faaccfg.h at knik0/faac@12d7414#diff-fa75728cbc344abe5291c5ae6bd3dfcd

      unsigned int aacObjectType;
  
 -    /* Allow mid/side coding */
 -    unsigned int allowMidside;
 +    /* Joint coding mode */
 +    unsigned int jointmode;
  
      /* Use one of the channels as LFE channel */

[s172262]

https://trac.ffmpeg.org/ticket/6809

Support for libfaac was removed some time ago.

[s172262]

remove faac option from ffmbc, ffmpeg@2.8 and libav. #20315

[ilovezfs]

@zmwangx I assume we're closing this out as well?

[zmwangx]

Hmm this is an entirely different issue. If faac made a breaking API change, one needs to talk to Libav upstream (which is not the same thing as FFmpeg upstream — Libav hates FFmpeg) if they want to continue the support. I have no problem removing the option from ffmbc and ffmpeg@2.8, though. We can always add it back if there's an uproar, and I doubt it.

[ilovezfs]

Josephs-MacBook-Pro:~ joe$ brew formula-analytics ffmpeg@2.8
install events in the last 30 days for ffmpeg@2.8
============================================================================================================================================================================================================================
 1 | ffmpeg@2.8                                                                                                                                                                                              |  85 |  70.25%
 2 | ffmpeg@2.8 --with-faac                                                                                                                                                                                  |   9 |   7.44%
 3 | ffmpeg@2.8 --with-libass --with-openjpeg --with-openssl --with-ffplay --with-tools --with-fdk-aac --with-x265 --with-webp --with-dcadec --with-faac --with-freetype --with-theora --with-libvorbis --wi |   9 |   7.44%
 4 | ffmpeg@2.8 --with-libass --with-openssl --with-ffplay --with-tools --with-fdk-aac --with-x265 --with-webp --with-dcadec --with-faac --with-freetype --with-theora --with-libvorbis --with-libvpx --with |   3 |   2.48%
 5 | ffmpeg@2.8 --with-openjpeg --with-openssl --with-fdk-aac --with-webp --with-faac --with-freetype                                                                                                        |   3 |   2.48%
 6 | ffmpeg@2.8 --with-libvpx                                                                                                                                                                                |   2 |   1.65%
 7 | ffmpeg@2.8 --with-fdk-aac                                                                                                                                                                               |   1 |   0.83%
 8 | ffmpeg@2.8 --with-ffplay                                                                                                                                                                                |   1 |   0.83%
 9 | ffmpeg@2.8 --with-libass --with-fdk-aac --with-x265 --with-freetype                                                                                                                                     |   1 |   0.83%
10 | ffmpeg@2.8 --with-libass --with-fdk-aac --with-x265 --with-freetype --with-libvorbis --with-libvpx --with-opus                                                                                          |   1 |   0.83%
11 | ffmpeg@2.8 --with-libass --with-ffplay --with-fdk-aac --with-x265 --with-freetype --with-libvorbis --with-libvpx --with-opus --with-libquvi                                                             |   1 |   0.83%
12 | ffmpeg@2.8 --with-openssl                                                                                                                                                                               |   1 |   0.83%
13 | ffmpeg@2.8 --with-openssl --with-fdk-aac --with-webp --with-faac --with-freetype                                                                                                                        |   1 |   0.83%
14 | ffmpeg@2.8 --with-rtmpdump --with-libass --with-opencore-amr --with-openjpeg --with-openssl --with-libssh --with-schroedinger --with-ffplay --with-tools --with-fdk-aac --with-libvidstab --with-x265 - |   1 |   0.83%
15 | ffmpeg@2.8 --with-rtmpdump --with-openssl                                                                                                                                                               |   1 |   0.83%
16 | ffmpeg@2.8 --with-tools --with-x265 --with-fontconfig --with-freetype --with-theora --with-libvorbis                                                                                                    |   1 |   0.83%
============================================================================================================================================================================================================================
Total                                                                                                                                                                                                        | 121 |    100%
============================================================================================================================================================================================================================
Josephs-MacBook-Pro:~ joe$ brew deps ffmbc
faac
lame
x264
xvid
Josephs-MacBook-Pro:~ joe$ brew formula-analytics ffmbc
install events in the last 30 days for ffmbc
============================================================================================================================================================================================================================
1 | ffmbc                                                                                                                                                                                                     | 25 |  69.44%
2 | ffmbc --with-theora --with-libvorbis --with-libvpx                                                                                                                                                        | 11 |  30.56%
============================================================================================================================================================================================================================
Total                                                                                                                                                                                                         | 36 |    100%
============================================================================================================================================================================================================================
Josephs-MacBook-Pro:~ joe$ 

I have no problem removing the option from ffmbc and ffmpeg@2.8, though. We can always add it back if there's an uproar, and I doubt it.

👍 lol

[ilovezfs]

Hmm this is an entirely different issue. If faac made a breaking API change, one needs to talk to Libav upstream (which is not the same thing as FFmpeg upstream — Libav hates FFmpeg) if they want to continue the support.

@s172262 did you contact libav?

[mwunsch]

I'm seeing a similar issue for gst-plugins-bad when built with faac.

[ilovezfs]

You'll need to contact gst-plugins-bad upstream about that.

[ilovezfs]

@s172262 @mwunsch this should now be fixed if you brew update and brew upgrade faac