qemu: expose RDTSCP to guests #100645
qemu: expose RDTSCP to guests #100645
Conversation
|
Patch seems alright to me, it seems like it's something Apple themselves have noticed, which boosts my confidence in it. Though I wonder if there's anything we can do to get some sort of movement on it upstream given it was submitted several months ago. |
|
I'm not sure we'd want to merge a patch that has not been accepted upstream yet but I'll leave it open for other maintainers to chime in. |
|
If it's not been accepted/merged upstream, not sure we want it. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I am waiting for the patch to be accepted in upstream qemu |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Upstream contributor apparently still wants to have the patch merged. I will ping this PR as soon as that happens. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Patch is under review upstream now https://patchew.org/QEMU/20220712221607.9933-1-f4bug@amsat.org/ |
BrewTestBot
added
the
automerge-skip
|
Patch was accepted upstream. https://gitlab.com/qemu-project/qemu/-/commit/d8cf2c29cc1077cd8f8ab0580b285bff92f09d1c Are there any remaining concerns to merge this? |
|
It should use the upstream commit in the formula. |
Adds a patch to resolve https://gitlab.com/qemu-project/qemu/-/issues/1011 Signed-off-by: Silvio Moioli <silvio@moioli.net>
BrewTestBot
removed
the
automerge-skip
Addressed, and rebased for good measure. |
|
馃 A scheduled task has triggered a merge. |
馃憢 Homebrew maintainers!
This is my first time contribution, I hope I did it right, apologies in advance if I didn't!
This is to fix a QEMU bug where the RDTSCP instruction, while available on the host, will not be exposed in the guest. Patch is taken from the QEMU mailing list - it has been recently proposed but it is not in master yet.
Original issue: https://gitlab.com/qemu-project/qemu/-/issues/1011
Issues indirectly caused: rancher-sandbox/rancher-desktop#1324, m3db/m3#3105 m3db/m3#3659 m3db/m3#3827
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?