cri-tools 1.24.0

[Porkepix]

Created with brew bump-formula-pr.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[badouralix]

@Porkepix the test failure likely comes from the change introduced in kubernetes-sigs/cri-tools#889

The actual error shows that this piece of code is executed https://github.com/kubernetes/kubernetes/blob/7af5a7bfc51d0455d8b2322ae9e72ed66fb1b8f9/pkg/kubelet/cri/remote/remote_runtime.go#L102-L129

I suggest we update the formula test as follow

homebrew-core/Formula/cri-tools.rb

Lines 40 to 43 in 3765b92

	crictl_output = shell_output(
	"#{bin}/crictl --runtime-endpoint unix:///var/run/nonexistent.sock --timeout 10ms info 2>&1", 1
	)
	assert_match "context deadline exceeded", crictl_output

- assert_match "context deadline exceeded", crictl_output 
+ assert_match "connect: no such file or directory", crictl_output 

Let me know if you want to recreate your pull request
Otherwise I can take care of it

[Porkepix]

Is there no way for people to reopen the PR? Because some other staled ones I tried to push changes before didn't result in the PR reopening :/

[badouralix]

Is there no way for people to reopen the PR?

I'm not sure, I guess opening a new pull request can help gain traction on visibility and reviewability

[Porkepix]

On the other hand it also create more noise in searches, notifications and so on, right?

[badouralix]

That's a fair point, probably worth mentioning it to the homebrew core maintainers to get their input on the matter
This discussion should not prevent us to bump to cri-tools 1.24.0 though

[SMillerDev]

Is there no way for people to reopen the PR?

Only as a maintainer or creator of the PR and since brew automation prohibits making duplicate PRs I think a lot of the PRs you opened and let expire will never be updated unless upstream complains.

[Porkepix]

Is there no way for people to reopen the PR?

Only as a maintainer or creator of the PR and since brew automation prohibits making duplicate PRs I think a lot of the PRs you opened and let expire will never be updated unless upstream complains.

So how, as the creator of the Pr, can I reopen it? Because I never found any way to reopen one, neither to use some of the tags. The result is that even if the branch is updated, it doesn't even rerun the CI on it.

[SMillerDev]

Labels are only for maintainers, but next to the comment button there is generally a reopen button

[Porkepix]

Labels are only for maintainers, but next to the comment button there is generally a reopen button

That's what I thought I remembered from other repositories, but not here:

[chenrui333]

@Porkepix the test failure likely comes from the change introduced in kubernetes-sigs/cri-tools#889

The actual error shows that this piece of code is executed https://github.com/kubernetes/kubernetes/blob/7af5a7bfc51d0455d8b2322ae9e72ed66fb1b8f9/pkg/kubelet/cri/remote/remote_runtime.go#L102-L129

I suggest we update the formula test as follow

homebrew-core/Formula/cri-tools.rb

Lines 40 to 43 in 3765b92

	crictl_output = shell_output(
	"#{bin}/crictl --runtime-endpoint unix:///var/run/nonexistent.sock --timeout 10ms info 2>&1", 1
	)
	assert_match "context deadline exceeded", crictl_output

- assert_match "context deadline exceeded", crictl_output 
+ assert_match "connect: no such file or directory", crictl_output 

Let me know if you want to recreate your pull request Otherwise I can take care of it

yeah, just came up with the same update in #101488 :)