pyqt5 5.8.1, sip 4.19.1, qscintilla2 2.10 #10171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last I checked, this causes the octave build to fail. We should not merge it until that is resolved (unless it already has been). |
ilovezfs
previously requested changes
Feb 21, 2017
|
@xu-cheng qscintilla2 build fails |
|
I checked, and this still causes octave to fail, as follows: |
|
octave-spindump.txt |
|
|
CC @schoeps the non-dev versions have been released and problem persists, as feared. |
I probably can only find time to work on this next week. Sorry about that. |
|
@xu-cheng that's no problem. I think we have 3 choices:
|
|
@xu-cheng looks like codequery needs a revision bump and to depend on qt5 not qt@5.7 |
|
Thanks |
|
@ilovezfs let's make the gui optional for octave. As far as I recall, this would make also the linux build easier. I will play around with qt5 but do not expect anything. I am a numerical analyst, not a gui programmer :) |
|
@schoeps unfortunately if we know it doesn't build, we'll just need to remove it. |
|
@ilovezfs I have seen other ports with "experimental" options.... |
|
@schoeps point them out, and I will remove them 🔥 |
|
@ilovezfs ok, you take that really serious. I will report such cases if I see them. For now, I will check how to fix octave... |
|
@schoeps fwiw, the problem seems to be that octave gui cannot quit. The build finishes without dying in Note that I'm building octave with this PR, and these diffs to octave and gnuplot (when not building --without-gnuplot): |
That quitting issue was already observed with the old qt5 but the compilation went along somehow. Nonetheless mac users are complaining on the mailing list a lot. Maybe I can do the tests using cli only. |
|
@schoeps that's really weird, since with the current octave bottle, there's no such quitting issue I can discern. There's something to be learned here hehe |
|
@ilovezfs really? on my machine quitting octave gui (after having plotted something) gives me the spinning beach ball of death.... |
|
Yeah, I can plot and then quit without a problem. |
|
@ilovezfs indeed octave compilation runs fine, one needs to kill Error log here: https://gist.github.com/schoeps/9ebb217220c875548f551c73163b153b. Anybody knows anyone with qt on mac expertise? |
@schoeps Can you clarify for me ... when you say "as it did before on my system" are you referring to a build against Qt 5.7 or Qt 5.8? |
|
@ilovezfs on my system octave-gui has been crashing on exit already with qt5.7. This did not effect the installation since the process did not become a zombie. With qt5.8 it is still crashing on exit but the process goes directly zombie and therefore already the installation stalls. EDIT: it could be also some other reason that happen to coincide with the change from qt4 to qt5. |
|
@ilovezfs The problem is known [1] but nobodies takes care. It seems also to happen to macport's octave [2]. [1] https://savannah.gnu.org/bugs/?50025 |
|
@ilovezfs Still trying but adding this into the formula before running tests fixes the installation.... however the application will still crash on exit. |
|
@schoeps does it crash on exit with |
|
@ilovezfs yes but it does not crash if one uses |
|
interesting |
|
@ilovezfs When using |
|
Hi. Quick comment: edits here for @ilovezfs wrote:
For # 2 could those formulae be frozen to their respective 5.7 versions, e.g. |
|
Unlikely, as it will set an unacceptable precedent. |
|
Hi, so what's the solution here? We can't just leave Also, loading multiple Qt versions into the formula build environ can lead to incorrect header resolution (at least that appears to be what is happening during build failures). |
|
@ilovezfs wrote:
After reviewing the |
|
|
Sorry, not following. If it is vendored within the |
|
Ah I didn't realize that was a strictly optional dependency for qscintilla2. |
|
Yes, so is the Qt Designer plugin. Should be fairly simple to vendor just the QScintilla2 package for its C++ API. Want me to do that? I have time available today that I can use for that. |
|
That would be lovely. |
|
@dakcarto did you have a chance to work on that? |
|
Hi, @ilovezfs, I worked on it yesterday. I have the QScintilla2 compilation and vendoring working fine, just having an issue with |
|
I've shipped https://github.com/Homebrew/homebrew-science/pull/5217 so we should be good to go here now. |
ilovezfs
changed the title
|
Shipped! Thanks @xu-cheng |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.