Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-cli 2.34.0 #102444

Closed
wants to merge 1 commit into from
Closed

apollo-cli 2.34.0 #102444

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented May 28, 2022

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` nodejs Node or npm use is a significant feature of the PR or issue labels May 28, 2022
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 28, 2022
@cho-m
Copy link
Member Author

cho-m commented May 29, 2022

Still has an issue with graphql in dependency tree where v15 is needed for part of code, but some other dependencies restrict graphql to v14.

Using --legacy-peer-deps to (incorrectly) pick v15 would "fix" issue. This is behavior in npm <= 6 so older node@14 may work. But these options both rely on incorrect dependency resolution to work around upstream issue, so it is possible that other parts of code would be broken.

@cho-m cho-m added upstream issue An upstream issue report is needed test failure CI fails while running the test-do block labels May 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 1, 2022
@cho-m
Copy link
Member Author

cho-m commented Jun 1, 2022

Closing for now. Probably need to wait until v3 apollographql/apollo-tooling#2611

Also noting that the upstream is planning to deprecate this https://github.com/apollographql/apollo-tooling/blob/master/packages/apollo/README.md

[2022-01-21] Note - Upcoming Deprecation Plans: We (Apollo) are working towards fully deprecating this repository and its related projects. Most of the functionality in this repository has been replaced by newer projects and the rest will be soon. We'll share detailed migration documentation when everything here is ready to be officially deprecated, but just a heads up in case you're planning on adopting anything here for a new project (which you still can of course if the tooling here works for you - support for this tooling will be minimal however).

@cho-m cho-m closed this Jun 1, 2022
@cho-m cho-m added the not merged PR was closed without being merged (and may need to be revisited) label Jun 1, 2022
@cho-m cho-m deleted the bump-apollo-cli-2.34.0 branch July 22, 2022 16:50
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. nodejs Node or npm use is a significant feature of the PR or issue not merged PR was closed without being merged (and may need to be revisited) outdated PR was locked due to age stale No recent activity test failure CI fails while running the test-do block upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants