Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphviz 4.0.0 #102587

Closed
wants to merge 1 commit into from
Closed

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label May 29, 2022
@chenrui333
Copy link
Member Author

brew test --retry --verbose plantuml

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels May 30, 2022
@chenrui333
Copy link
Member Author

chenrui333 commented May 30, 2022

brew test --retry --verbose plantuml

need a upstream patch for parsing out graphviz version

- \\s([23])\\.(\\d\\d?)\\D
+ \\s([234])\\.(\\d\\d?)\\D
	public static int retrieveVersion(String s) {
		if (s == null)
			return -1;

		final Pattern p = Pattern.compile("\\s([23])\\.(\\d\\d?)\\D");
		final Matcher m = p.matcher(s);
		if (m.find() == false)
			return -1;

		return 100 * Integer.parseInt(m.group(1)) + Integer.parseInt(m.group(2));
	}

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 1, 2022
@carlocab
Copy link
Member

carlocab commented Jun 1, 2022

Probably needs something like #95933.

@github-actions github-actions bot removed the stale No recent activity label Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 3, 2022
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Jun 4, 2022
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Jun 4, 2022
@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue and removed upstream issue An upstream issue report is needed in progress Stale bot should stay away labels Jul 16, 2022
@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022
@chenrui333 chenrui333 deleted the bump-graphviz-4.0.0 branch December 18, 2022 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-requeued PR has been re-added to the queue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants