Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borgmatic 1.6.1 #102656

Closed
wants to merge 2 commits into from
Closed

borgmatic 1.6.1 #102656

wants to merge 2 commits into from

Conversation

adidalal
Copy link
Contributor

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` python Python use is a significant feature of the PR or issue labels May 31, 2022
@adidalal
Copy link
Contributor Author

adidalal commented May 31, 2022

It looks like this test is failing due to a behavior change in borgmatic:

==> /opt/homebrew/Cellar/borgmatic/1.6.1/bin/borgmatic -v 2 --config /private/tmp/borgmatic-test-20220530-96174-w431n3/config.yml --init --encryption repokey
[50](https://github.com/Homebrew/homebrew-core/runs/6664197577?check_suite_focus=true#step:6:51)
  Ensuring legacy configuration is upgraded
[51](https://github.com/Homebrew/homebrew-core/runs/6664197577?check_suite_focus=true#step:6:52)
  /private/tmp/borgmatic-test-20220530-96174-w431n3/borg --version --debug --show-rc
[52](https://github.com/Homebrew/homebrew-core/runs/6664197577?check_suite_focus=true#step:6:53)
  /private/tmp/borgmatic-test-20220530-96174-w431n3/config.yml: Error getting local Borg version
[53](https://github.com/Homebrew/homebrew-core/runs/6664197577?check_suite_focus=true#step:6:54)
  Could not parse Borg version string

Specifically, this commit where it's now checking for a version of borg, in order to decide to execute the compact command or not.

I believe the fix would be to update the borg stub in the test.

For example, borg --version returns borg 1.2.0

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants