dmd: fix VERSION file

[John-Colvin]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
• Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
• Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

---

I would have done this with a patch, but it seemed easier this way., especially as it will probably happen again and so we want to stay up to date regardless.

[MikeMcQuaid]

Does (buildpath/"VERSION").write version work?

[John-Colvin]

Have to rm first because otherwise it complains about overwriting an
existing file.
On 10 May 2016 9:33 am, "Mike McQuaid" notifications@github.com wrote:

In Formula/dmd.rb
#1040 (comment)
:

@@ -47,6 +48,11 @@ class Dmd < Formula
def install
make_args = ["INSTALL_DIR=#{prefix}", "MODEL=#{Hardware::CPU.bits}", "-f", "posix.mak"]

• VERSION file is wrong upstream, has happened before, so we just overwrite it here.

• version_file = (buildpath/"VERSION")
• rm version_file
• version_file.write version

Does (buildpath/"VERSION").write version work?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/homebrew-core/pull/1040/files/b12f2d681b433bba2522f0651bad81141fc2b35e#r62630959

[MikeMcQuaid]

Could you complain to upstream about this happening in an issue? Probably up for merging this anyway, though.

[John-Colvin]

It's recognised as a problem upstream, but keeps happening nonetheless...
On 10 May 2016 9:34 am, "Mike McQuaid" notifications@github.com wrote:

Could you complain to upstream about this happening in an issue? Probably
up for merging this anyway, though.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1040 (comment)

[MikeMcQuaid]

Thanks again @John-Colvin!

For future reference the preferred commit message format is dmd: fix VERSION file.. Please check the issue template in future PRs where this format is detailed in the linked Contributing guidelines. Thanks!