Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipe-rename 1.4.2 (new formula) #105108

Closed
wants to merge 1 commit into from
Closed

pipe-rename 1.4.2 (new formula) #105108

wants to merge 1 commit into from

Conversation

PythonCoderAS
Copy link
Contributor

@PythonCoderAS PythonCoderAS commented Jul 5, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I had to use --version as the test because for normal usage a tty is required.

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Jul 5, 2022
@carlocab carlocab changed the title Add pipe-rename 1.4.2 pipe-rename 1.4.2 (new formula) Jul 5, 2022
@carlocab
Copy link
Member

carlocab commented Jul 5, 2022

Please use the preferred commit-message style for homebrew/core. We put the name of the formula first in commit-message headings.

For new formulae:

At Homebrew, we like to put the name of the formula up front like so: foobar 7.3 (new formula).

For existing formulae:

The preferred commit message format for simple version updates is foobar 7.3 and for fixes is foobar: fix flibble matrix..

Refer to the commit style guide for more details. Also, when making further changes to your pull request, use the following guidelines to make sure that @BrewTestBot can merge your commits:

  • One formula per commit; one commit per formula.
  • Keep merge commits out of the pull request.

class PipeRename < Formula
desc "Rename your files using your favorite text editor"
homepage "https://github.com/marcusbuffett/pipe-rename"
url "https://crates.io/api/v1/crates/pipe-rename/1.4.2/download"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a GitHub tarball?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no github releases and the last github tag is version 1.1.6 from September 2020.

Formula/pipe-rename.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

LGTM

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 7, 2022
@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@chenrui333
Copy link
Member

@PythonCoderAS, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@PythonCoderAS PythonCoderAS deleted the add-pipe-rename branch July 14, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants