llvm 15.0.0 #106925

carlocab · 2022-07-30T16:05:53Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The last version bump took ages, so I'd like to get started early to try to get it done faster this time.

Things I'd like to fix along the way:

Avoiding mixed linkage with system libc++ and the bundled libc++
Broken Python bindings -- they can't find libLLVM and libclang

I have ideas for how to fix the above two, but I've written these issues down here so I don't forget. Nevertheless, suggestions on how to fix them welcome.

carlocab · 2022-08-18T05:02:27Z

Formula/llvm.rb

+    # Linking with these causes you subtle problems on macOS,
+    # since everything loads `/usr/lib/libc++.1.dylib`.
+    # https://github.com/Homebrew/homebrew-core/issues/96915
+    runtimes += %w[libcxx libcxxabi] if OS.linux?


Thoughts on this, @Bo98?

On the one hand, I feel like it might be a bit of an overreaction. On the other, we already prefer linking with /usr/lib/libc++.1.dylib anyway, so it's not like we have much use for these...

Also, I can move this up into the else block above. I'll do so on the next run.

I agree that these need to go. Or if for some reason they need to ship, then they cannot live in lib anymore.

Ideally the C++ headers would stay however, since I think those are necessary for clang++ usage on < 10.15.3 SDK and shouldn't affect anything on newer SDKs.

Alternative is to symlink the C++ header directory to the CLT header directory. Not entirely sure what would work better.

I'm still a little sceptical that this is the right solution, though, since there's been lots of use of the bundled libc++, even in other formulae (despite our efforts to avoid it). So I don't think the issue is that you're linking with two versions of libc++ -- that's been happening for a long time.

Trying this.

Though, the scan-build test is failing, even after trying to point it to bin/"clang". Seems to be libc++-related, since it didn't fail when I removed libc++.

Moving libc++ might end up fixing that, we'll see.

Oh wait, didn't notice it's already failing with the change. Does LLVM 14 fail with a similar absolute clang reference?

Does LLVM 14 fail with a similar absolute clang reference?

It does not. It works with an unqualified clang++ or a bin/"clang++".

Error looks related to libc++ headers.

Formula/llvm.rb

carlocab · 2022-08-20T12:16:48Z

macOS build fails with

CMake Error at /tmp/llvm-20220820-87389-nfadr9/llvm-project-15.0.0rc2.src/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:73 (message):
  Failed to determine SDK version for "iphonesimulator" SDK
Call Stack (most recent call first):
  /tmp/llvm-20220820-87389-nfadr9/llvm-project-15.0.0rc2.src/compiler-rt/cmake/builtin-config-ix.cmake:120 (find_darwin_sdk_version)
  CMakeLists.txt:51 (include)

carlocab · 2022-08-20T12:28:18Z

Linux fails at building OpenMP with:

/tmp/llvm-20220820-9038-1vp6qle/llvm-project-15.0.0rc2.src/openmp/libomptarget/plugins/amdgpu/impl/system.cpp:8:10: fatal error: 'libelf.h' file not f
ound
#include <libelf.h>
         ^~~~~~~~~~

Bo98 · 2022-08-20T15:42:33Z

Formula/llvm.rb


    if OS.mac?
      args << "-DLLVM_BUILD_LLVM_C_DYLIB=ON"
      args << "-DLLVM_ENABLE_LIBCXX=ON"
      args << "-DDEFAULT_SYSROOT=#{macos_sdk}" if macos_sdk
      runtimes_cmake_args << "-DCMAKE_INSTALL_RPATH=#{rpath}"
+      # Disable builds for OSes not supported by the CLT SDK.
+      runtimes_cmake_args += %w[I WATCH TV].map { |os| "-DCOMPILER_RT_ENABLE_#{os}OS=OFF" }


I WATCH TV

😄

What's changed here though to need this?

This llvm/llvm-project@a680c21 seems to lead to #106925 (comment).

(Yes, I chuckled at I WATCH TV too. Though really only the I is potentially needed right now.)

Actually, I'm not sure why this is failing. find_darwin_sdk_version runs xcrun --sdk iphonesimulator --show-sdk-version and checks that it returns 0. I tried this on an ARM runner and it seems to work.

Is it because we set DEVELOPER_DIR or something?

I suppose we could just require Xcode to build this again...

I think you're correct. It'll probably be an issue for CLT-only systems too.

I suppose we could just require Xcode to build this again...

I'd rather not.

You probably won't be able to submit apps for those platforms when built with Homebrew LLVM so I don't think this is an issue. Was just mostly interested why it broke.

Homebrew is also a macOS package manager and offer no iOS support in anything else we ship.

You probably won't be able to submit apps for those platforms when built with Homebrew LLVM so I don't think this is an issue. Was just mostly interested why it broke.

Maybe not, but it might be nice to have access to sanitisers, etc, for debugging.

Homebrew is also a macOS package manager and offer no iOS support in anything else we ship.

Can we force this to use the Xcode SDK if it's available but fall back to the CLT and disable iOS builds if not?

We could but it's tricky to selectively apply it to just iOS etc SDKs.

Setting DARWIN_iphonesimulator_OVERRIDE_SDK_VERSION (etc) is possible however. It seems like before it might have just auto-disabled if the SDK is not available (maybe? - need to check) so this feels like a bit of a regression anyway and I don't think it should be a fatal error. Maybe worth comparing the bottle with a CLT-only build at some point.

Formula/llvm.rb

carlocab · 2022-08-21T08:41:18Z

ARM Monterey failures:

Error: 41 failed steps!
brew linkage --test c2rust
brew test --retry --verbose c2rust
brew linkage --test castxml
brew test --retry --verbose castxml
brew linkage --test ccls
brew test --retry --verbose ccls
brew linkage --test chapel
brew test --retry --verbose chapel
brew linkage --test clazy
brew test --retry --verbose clazy
brew linkage --test coin3d
brew linkage --test crystal
brew test --retry --verbose crystal
brew linkage --test csound
brew test --retry --verbose csound
brew test --retry --verbose dpp
brew linkage --test enzyme
brew test --retry --verbose enzyme
brew linkage --test faust
brew test --retry --verbose faust
brew linkage --test halide
brew test --retry --verbose halide
brew linkage --test include-what-you-use
brew test --retry --verbose include-what-you-use
brew linkage --test ispc
brew test --retry --verbose ispc
brew linkage --test ldc
brew test --retry --verbose ldc
brew linkage --test nvc
brew linkage --test odin
brew test --retry --verbose odin
brew linkage --test pocl
brew test --retry --verbose pocl
brew linkage --test pyside
brew linkage --test pyside@2
brew linkage --test rtags
brew test --retry --verbose scry
brew linkage --test spirv-llvm-translator
brew test --retry --verbose spirv-llvm-translator
brew linkage --test standardese
brew linkage --test symengine

ARM Big Sur failures are similar.

Every linkage failure I looked at is for libc++. The test failures are due to missing symbols in libLLVM, which is typical.

carlocab · 2022-08-21T12:49:43Z

macOS failures all look pretty similar, except Catalina, which failed to build.

This is no longer needed after Homebrew#106925.

We don't need to carry around this build-time resource anymore. The issue that required this has been fixed in Homebrew#106925.

This is no longer needed after #106925.

We don't need to carry around this build-time resource anymore. The issue that required this has been fixed in #106925.

In Homebrew#106925, I enabled LTO for our LLVM build. This creates static archives that contain LLVM bitcode instead of object code. This makes the static archives more difficult to use, requiring workarounds such as https://github.com/Homebrew/homebrew-core/blob/c01f1794fc3decce04b71cae03966213fc7af34d/Formula/enzyme.rb#L30 and has caused problems for multiple downstream projects. We can fix this by converting the bitcode into object code, which is what Fedora does with their LLVM build. They also build their toolchain with LTO. Alternatively, we can disable LTO, but that foregoes significant speedups we get from enabling it. While we're here, let's add some test coverage for features that were recently enabled that we don't test. Fixes: ziglang/zig#12923 halide/Halide#7055 mesonbuild/meson#10879 Homebrew/discussions#3666

In #106925, I enabled LTO for our LLVM build. This creates static archives that contain LLVM bitcode instead of object code. This makes the static archives more difficult to use, requiring workarounds such as https://github.com/Homebrew/homebrew-core/blob/c01f1794fc3decce04b71cae03966213fc7af34d/Formula/enzyme.rb#L30 and has caused problems for multiple downstream projects. We can fix this by converting the bitcode into object code, which is what Fedora does with their LLVM build. They also build their toolchain with LTO. Alternatively, we can disable LTO, but that foregoes significant speedups we get from enabling it. While we're here, let's add some test coverage for features that were recently enabled that we don't test. Fixes: ziglang/zig#12923 halide/Halide#7055 mesonbuild/meson#10879 Homebrew/discussions#3666 Closes #112154. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

BrewTestBot added long build Needs CI-long-timeout python Python use is a significant feature of the PR or issue labels Jul 30, 2022

carlocab added the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label Jul 30, 2022

BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 30, 2022

carlocab added the do not merge label Jul 30, 2022

carlocab force-pushed the llvm-15-rc1 branch from 773050c to 2390aa2 Compare July 30, 2022 18:39

carlocab mentioned this pull request Aug 13, 2022

lldb 14.0.6 (new formula) #103879

Closed

6 tasks

cho-m added the CI-linux-self-hosted Build on Linux self-hosted runner label Aug 16, 2022

carlocab mentioned this pull request Aug 18, 2022

Problem when linking to clang and getting the Homebrew libc++ #96915

Closed

2 tasks

carlocab force-pushed the llvm-15-rc1 branch from 531d4ed to 01001cc Compare August 18, 2022 05:01

carlocab changed the title ~~llvm 15.0.0-rc1~~ llvm 15.0.0-rc2 Aug 18, 2022

carlocab commented Aug 18, 2022

View reviewed changes

carlocab force-pushed the llvm-15-rc1 branch from 01001cc to 91b0ce4 Compare August 20, 2022 07:58

carlocab added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 20, 2022

carlocab commented Aug 20, 2022

View reviewed changes

Formula/llvm.rb Outdated Show resolved Hide resolved

carlocab force-pushed the llvm-15-rc1 branch 3 times, most recently from 80a4c56 to 08f39a8 Compare August 20, 2022 13:11

Bo98 reviewed Aug 20, 2022

View reviewed changes

carlocab force-pushed the llvm-15-rc1 branch from 08f39a8 to 75d84be Compare August 20, 2022 17:29

chenrui333 removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Aug 20, 2022

carlocab added the CI-long-timeout Use longer GitHub Actions CI timeout. label Aug 21, 2022

carlocab force-pushed the llvm-15-rc1 branch from a694d2a to 78d9bd2 Compare August 21, 2022 05:52

fxcoudert removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Aug 21, 2022

carlocab added the CI-long-timeout Use longer GitHub Actions CI timeout. label Aug 21, 2022

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

pdnsrec: add reminder to remove workaround.

61cd627

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

poac: add reminder to remove workaround.

0767fce

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

snappy: add reminder to remove workaround.

de1213e

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

v8: add reminder to remove workaround.

b504ad1

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

vte3: add reminder to remove workaround.

5e96013

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

vtk: add reminder to remove workaround.

54ea221

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

vtk@8.2: add reminder to remove workaround.

eef521a

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

xgboost: add reminder to remove workaround.

eff358f

This is no longer needed after Homebrew#106925.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Sep 19, 2022

vineyard: use libclang Python bindings from LLVM

d214fc6

We don't need to carry around this build-time resource anymore. The issue that required this has been fixed in Homebrew#106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

deno: add reminder to remove workaround.

a3d6a00

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

grokj2k: add reminder to remove workaround.

1f97971

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

grpc: add reminder to remove workaround.

305b08f

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

mold: add reminder to remove workaround.

e25a199

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

node: add reminder to remove workaround.

a5af543

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

pdnsrec: add reminder to remove workaround.

f3c3de7

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

poac: add reminder to remove workaround.

0c786ea

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

snappy: add reminder to remove workaround.

d3a7724

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

v8: add reminder to remove workaround.

cd3f950

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

vte3: add reminder to remove workaround.

b564842

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

vtk: add reminder to remove workaround.

d1ee8a7

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

vtk@8.2: add reminder to remove workaround.

b318cd0

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

xgboost: add reminder to remove workaround.

fb10221

This is no longer needed after #106925.

carlocab added a commit that referenced this pull request Sep 19, 2022

vineyard: use libclang Python bindings from LLVM (#111136)

ab25a67

We don't need to carry around this build-time resource anymore. The issue that required this has been fixed in #106925.

carlocab mentioned this pull request Oct 2, 2022

llvm: convert bitcode in static archives to object code #112154

Closed

6 tasks

github-actions bot added the outdated PR was locked due to age label Oct 20, 2022

github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

llvm 15.0.0 #106925

llvm 15.0.0 #106925

carlocab commented Jul 30, 2022

carlocab Aug 18, 2022

carlocab Aug 20, 2022

Bo98 Aug 20, 2022 •

edited

Bo98 Aug 20, 2022 •

edited

carlocab Aug 20, 2022 •

edited

carlocab Aug 28, 2022

Bo98 Aug 28, 2022

Bo98 Aug 28, 2022

carlocab Aug 29, 2022

carlocab Aug 29, 2022

carlocab commented Aug 20, 2022

carlocab commented Aug 20, 2022

Bo98 Aug 20, 2022

carlocab Aug 20, 2022

carlocab Aug 20, 2022

carlocab Aug 20, 2022

Bo98 Aug 20, 2022 •

edited

Bo98 Aug 20, 2022 •

edited

carlocab Aug 21, 2022

Bo98 Aug 21, 2022

carlocab commented Aug 21, 2022

carlocab commented Aug 21, 2022

llvm 15.0.0 #106925

llvm 15.0.0 #106925

Conversation

carlocab commented Jul 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bo98 Aug 20, 2022 • edited

Choose a reason for hiding this comment

Bo98 Aug 20, 2022 • edited

Choose a reason for hiding this comment

carlocab Aug 20, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlocab commented Aug 20, 2022

carlocab commented Aug 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bo98 Aug 20, 2022 • edited

Choose a reason for hiding this comment

Bo98 Aug 20, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlocab commented Aug 21, 2022

carlocab commented Aug 21, 2022

Bo98 Aug 20, 2022 •

edited

Bo98 Aug 20, 2022 •

edited

carlocab Aug 20, 2022 •

edited

Bo98 Aug 20, 2022 •

edited

Bo98 Aug 20, 2022 •

edited