Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitfs: fix test failure #107867

Merged
merged 1 commit into from
Aug 12, 2022
Merged

gitfs: fix test failure #107867

merged 1 commit into from
Aug 12, 2022

Conversation

carlocab
Copy link
Member

Fixes a CI failure seen at #107517.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Aug 12, 2022
@carlocab
Copy link
Member Author

Previous attempts: #87098, #90923

I may just fix the python3 references for now in case getting this to build against python3.10 doesn't work.

Formula/gitfs.rb Outdated
depends_on "python@3.9"
depends_on "python@3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous attempt: #90923
Upstream pending PR: presslabs/gitfs#382

@carlocab carlocab added CI-no-bottles Merge without publishing bottles and removed python-3.10-migration labels Aug 12, 2022
@carlocab carlocab changed the title gitfs: migrate to python@3.10 gitfs: fix test failure Aug 12, 2022
@carlocab carlocab merged commit 0820eec into Homebrew:master Aug 12, 2022
@carlocab carlocab deleted the gitfs-py310 branch August 12, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants