ghostscript 10.0.0 #111494
ghostscript 10.0.0 #111494
Conversation
BrewTestBot
added
the
bump-formula-pr
cho-m
force-pushed
the
bump-ghostscript-10.0.0
branch
from
54ab0af
to
b937941
Compare
cho-m
added
CI-no-fail-fast
| else | ||
| system "./configure", *std_configure_args, *args | ||
| end | ||
| libs = %w[expat freetype jbig2dec jpeg lcms2mt libpng openjpeg tiff zlib] |
There was a problem hiding this comment.
No system tesseract or leptonica? Maybe we could just manually pass the right -I, -L and -l flags directly to configure or make.
There was a problem hiding this comment.
Configure script will check for local source code and auto-disable feature if it doesn't exist https://git.ghostscript.com/?p=ghostpdl.git;a=blob;f=configure.ac;h=bb578250c2a3ba40c3479e57fd59e07f2c52e968;hb=f9673cbc87df8331c5b3928d91fde25d0f111e9c#l981
May be able to workaround, but not sure if worth the effort.
Some Linux repositories just disable OCR support, e.g. Arch https://github.com/archlinux/svntogit-packages/blob/packages/ghostscript/trunk/PKGBUILD#L34-L41
# 1) inclusion of the tesseract/leptonica sources for OCR capabilities
# at the moment we do not support linking with tesseract/leptonica shared libraries.
# As is normal with such included libraries, deleting those directories and (re)running
# configure (on Unix like systems) will automatically build without the OCR functionality.
# increases package size ghostpcl 2.7->4.9MB | ghostscript 18->23MB | ghostxps 2,7->4.9MB
# https://www.ghostscript.com/doc/9.54.0/VectorDevices.htm#UseOCR -
# this doesn't seem to be worth to keep enabled until linking with shared libs is supported
rm -r tesseract leptonica
There was a problem hiding this comment.
Ok, let me see about filing an issue upstream then.
There was a problem hiding this comment.
Oh, someone beat us to it by a month: https://bugs.ghostscript.com/show_bug.cgi?id=705764
| url :stable | ||
| regex(/href=.*?ghostpdl[._-]v?(\d+(?:\.\d+)+)\.t/i) | ||
| strategy :github_latest | ||
| url :head | ||
| regex(/^ghostpdl[._-]v?(\d+(?:\.\d+)+)$/i) |
There was a problem hiding this comment.
Livecheck was failing, which I think was due to number of uploaded files. They don't show up on detected release page https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/tag/gs1000. They do show up on https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/expanded_assets/gs1000
Went and reverted livecheck to previous one, which the comment was for. This may cause issues given it had issues with 9.56.1 release #98910.
There was a problem hiding this comment.
This failure is due to the changes described in Homebrew/brew#13853 (i.e., GitHub doesn't include the asset list in the HTML now). I was about to create a PR to update this livecheck block but I'll add some suggestions here instead.
| url :stable | ||
| regex(/href=.*?ghostpdl[._-]v?(\d+(?:\.\d+)+)\.t/i) | ||
| strategy :github_latest | ||
| url :head | ||
| regex(/^ghostpdl[._-]v?(\d+(?:\.\d+)+)$/i) |
There was a problem hiding this comment.
This failure is due to the changes described in Homebrew/brew#13853 (i.e., GitHub doesn't include the asset list in the HTML now). I was about to create a PR to update this livecheck block but I'll add some suggestions here instead.
| # We check the tags from the `head` repository because the GitHub tags are | ||
| # formatted ambiguously, like `gs9533` (corresponding to version 9.53.3). |
There was a problem hiding this comment.
| # We check the tags from the `head` repository because the GitHub tags are | |
| # formatted ambiguously, like `gs9533` (corresponding to version 9.53.3). | |
| # We identify the latest version from the first-party website because the | |
| # GitHub tags are formatted ambiguously (e.g. `gs9533` for version 9.53.3). |
| url :head | ||
| regex(/^ghostpdl[._-]v?(\d+(?:\.\d+)+)$/i) |
There was a problem hiding this comment.
| url :head | |
| regex(/^ghostpdl[._-]v?(\d+(?:\.\d+)+)$/i) | |
| url "https://www.ghostscript.com/json/settings.json" | |
| regex(/["']GS_VER["']:\s*?["']v?(\d+(?:\.\d+)+)["']/i) |
Checking the Git tags technically works but the release tarball may not be available yet when the tag is created (i.e., this is the reason behind using the GithubLatest strategy here). The first-party download page links to the latest GhostPDL tarball on GitHub but the link is generated using JavaScript from a JSON file. The suggestion above matches the version from the JSON file, so we shouldn't have issues with livecheck surfacing a new version before the tarball is available.
In the future, I'll update this to use a Json strategy (which will properly parse the JSON and extract the value for the GS_VER field) but I still have to work my way to creating that PR (i.e., the work's done but I have some other brew PRs to tackle first).
|
This will need a rebase for Also, this should probably be reported upstream: This used to be fixed by a patch we were carrying. |
carlocab
force-pushed
the
bump-ghostscript-10.0.0
branch
from
c1223b0
to
b0cf0a2
Compare
carlocab
added
CI-long-timeout
Created with
brew bump-formula-pr.resourceblocks may require updates.