Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxsuite 0.2.2 (new formula) #111825

Closed
wants to merge 3 commits into from
Closed

Conversation

jcarpent
Copy link
Contributor

@jcarpent jcarpent commented Sep 27, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue labels Sep 27, 2022
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 28, 2022
@fxcoudert
Copy link
Member

It fails on ARM (Apple Silicon) because it includes a x86-only header:

14/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/14.0.0/include/mmintrin.h::214:: 2error: :"This header is only meant to be used on x86 and x64 architecture" 

And on Intel, the test fails:

  ==> Testing proxsuite
  ==> /usr/local/opt/python@3.10/libexec/bin/python -c import proxsuite
  qp = proxsuite.proxqp.dense.QP(10,0,0)
  assert qp.model.H.shape[0] == 10 and qp.model.H.shape[1] == 10
  Traceback (most recent call last):
  Error: test failed
    File "<string>", line 3, in <module>
  ModuleNotFoundError: No module named 'numpy'

@jcarpent jcarpent force-pushed the topic/proxsuite branch 2 times, most recently from 3a05812 to 3d82dd6 Compare October 18, 2022 13:15
@jcarpent jcarpent changed the title proxsuite 0.1.2 (new formula) proxsuite 0.2.1 (new formula) Oct 18, 2022
@jcarpent jcarpent force-pushed the topic/proxsuite branch 5 times, most recently from 4063ab7 to 32b3ec3 Compare October 19, 2022 05:58
@jcarpent jcarpent changed the title proxsuite 0.2.1 (new formula) proxsuite 0.2.2 (new formula) Oct 19, 2022
@jcarpent
Copy link
Contributor Author

@fxcoudert @carlocab I've fixed the issue with @fabinsh to properly integrate ProxSuite within HomeBrew.
This PR is ready for review.

@jcarpent
Copy link
Contributor Author

Thanks a lot @fxcoudert @carlocab for your time and help.

Formula/proxsuite.rb Outdated Show resolved Hide resolved
Formula/proxsuite.rb Show resolved Hide resolved
Formula/proxsuite.rb Outdated Show resolved Hide resolved
Formula/proxsuite.rb Outdated Show resolved Hide resolved
@jcarpent
Copy link
Contributor Author

Thanks @SMillerDev for the feedback. I've handled most of them, except the one to properly find Simde.

@jcarpent
Copy link
Contributor Author

@SMillerDev Thanks a lot for the review process.
Do you have in mind a timeline for releasing this package in the core of Homebrew?

@SMillerDev
Copy link
Member

When it's done and reviewed

chenrui333
chenrui333 previously approved these changes Oct 27, 2022
@chenrui333
Copy link
Member

LGTM

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants