Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mxnet 1.9.1 (new formula) #111872

Closed
wants to merge 1 commit into from
Closed

mxnet 1.9.1 (new formula) #111872

wants to merge 1 commit into from

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Sep 28, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Deep learning library

Notes

  • OpenMP is disabled since it tries to install and link a local copy, even when libomp is present and found
 -- Compiling with OpenMP
-- Found OpenMP_C: -Xclang -fopenmp (found version "5.0") 
-- Found OpenMP_CXX: -Xclang -fopenmp (found version "5.0") 
-- Found OpenMP: TRUE (found version "5.0")  
...
-- Installing: /usr/local/Cellar/mxnet/1.9.1/lib/libomp.dylib
-- Installing: /usr/local/Cellar/mxnet/1.9.1/include/omp.h
-- Installing: /usr/local/Cellar/mxnet/1.9.1/include/omp-tools.h
-- Installing: /usr/local/Cellar/mxnet/1.9.1/include/ompt.h

@BrewTestBot BrewTestBot added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 28, 2022
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 28, 2022
Formula/mxnet.rb Outdated

depends_on "cmake" => :build
depends_on "python@3.10" => :build
depends_on arch: :x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a tracking issue for ARM support?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to try -DUSE_SSE=OFF for ARM

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 7, 2022
@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@ankane
Copy link
Contributor Author

ankane commented Oct 8, 2022

Thanks @chenrui333 and @carlocab!

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants