Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sha256 in xplanetfx #11533

Merged
merged 1 commit into from Mar 25, 2017
Merged

fix sha256 in xplanetfx #11533

merged 1 commit into from Mar 25, 2017

Conversation

blogabe
Copy link

@blogabe blogabe commented Mar 24, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@neutric
Copy link
Contributor

neutric commented Mar 24, 2017

@blogabe Before we can proceed, we'll need to know why the file has changed. Is upstream aware of this issue? If not, would you be so kind and let them know about the checksum change and then report back to us? See this for an example of what we are looking for.

@neutric neutric added the needs response Needs a response from the issue/PR author label Mar 24, 2017
@blogabe
Copy link
Author

blogabe commented Mar 24, 2017

I don't think it was working for some time. Running brew audit --strict on the formula before fixing it didn't identify any errors. It wasn't until I tried installing it that the alert came up. My point is, I don't know if it's an upstream issue or if the formula had the wrong sha since the last update maybe 4 months ago.

@BrewTestBot BrewTestBot removed the needs response Needs a response from the issue/PR author label Mar 24, 2017
@neutric
Copy link
Contributor

neutric commented Mar 24, 2017

sha256 was changed during the version bump to 2.6.12 and bottles were built successfully, so what we have now was the correct checksum at some point. Upstream uses a comment form as "bug reporting facility". Would you mind asking real quick whether they are aware of the checksum change and why it changed?

@blogabe
Copy link
Author

blogabe commented Mar 24, 2017

From upstream: "I set up a new key for verification cause newer Ubuntu and derivates were complaining about the old one."

@neutric
Copy link
Contributor

neutric commented Mar 24, 2017

Link to upstream's response for good record keeping. 🗃

I guess a version bump by upstream would have communicated this change better, as @ilovezfs said recently, but what are you gonna do. Thanks for getting clarification, @blogabe!

@fxcoudert fxcoudert merged commit 996b3f9 into Homebrew:master Mar 25, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
@blogabe blogabe deleted the xpfx-fix branch January 24, 2019 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants