openrtsp 2022.11.19

[BrewTestBot]

Created by brew bump

---

Created with brew bump-formula-pr.

[chenrui333]

  GroupsockHelper.cpp:745:30: error: expected expression
        MAKE_SOCKADDR_IN6(name,IN6ADDR_ANY_INIT, 0);
                               ^

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[ZhongRuoyu]

This should fix the build:

index eb359069ed7..2e6389c7292 100644
--- a/Formula/openrtsp.rb
+++ b/Formula/openrtsp.rb
@@ -27,6 +27,11 @@ class Openrtsp < Formula
   depends_on "openssl@3"
 
   def install
+    # Fix usage of IN6ADDR_ANY_INIT macro (error: expected expression). See:
+    # https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/netinet_in.h.html
+    inreplace "groupsock/GroupsockHelper.cpp", "IN6ADDR_ANY_INIT",
+                                               "in6addr_any"
+
     # Avoid linkage to system OpenSSL
     libs = [
       Formula["openssl@3"].opt_lib/shared_library("libcrypto"),

The problem is, this macro MAKE_SOCKADDR_IN6(name,IN6ADDR_ANY_INIT, 0); expands to:

struct sockaddr_in6 name;
memset(&name, 0, sizeof name);
name.sin6_family = AF_INET6;
name.sin6_addr = IN6ADDR_ANY_INIT;
name.sin6_port = (0);

... where IN6ADDR_ANY_INIT, in turn, expands to {{{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }}}. However, that is an initializer list, which is only meant for initialization ¹. To assign to existing objects, the external variable in6addr_any, also defined in the same header <netinet/in.h>, comes into play ².

---

Update: by the way, this patch still applies to the newest version 2022.12.01.

Footnotes

1. https://en.cppreference.com/w/c/language/struct_initialization ↩

2. https://pubs.opengroup.org/onlinepubs/009695399/basedefs/netinet/in.h.html ↩

[BrewTestBot]

@chenrui333 has triggered a merge.