Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jvm-mon 0.3 (new formula) #11661

Merged
merged 2 commits into from
Mar 30, 2017
Merged

jvm-mon 0.3 (new formula) #11661

merged 2 commits into from
Mar 30, 2017

Conversation

ajermakovics
Copy link
Contributor

@ajermakovics ajermakovics commented Mar 27, 2017 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Adds a new formula for jvm-mon - Console based JVM monitoring tool

@ajermakovics ajermakovics mentioned this pull request Mar 27, 2017
Closed
@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Mar 27, 2017
fxcoudert
fxcoudert requested changes Mar 27, 2017
View reviewed changes
Formula/jvm-mon.rb Outdated
end

test do
system "false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope :(
We'll need a test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough:) Added

bfontaine
bfontaine reviewed Mar 27, 2017
View reviewed changes
Formula/jvm-mon.rb Outdated
def install
rm_f Dir["bin/*.bat"]
libexec.install Dir["*"]
bin.install_symlink libexec/"bin"/"jvm-mon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use libexec/"bin/jvm-mon"

bfontaine
bfontaine suggested changes Mar 27, 2017
View reviewed changes
Formula/jvm-mon.rb Outdated
@@ -0,0 +1,18 @@
class JvmMon < Formula
desc "Console based JVM monitoring"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Console based" -> "Console-based"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed

@fxcoudert
Copy link
Member 

==> echo q | /usr/local/Cellar/jvm-mon/0.3/bin/jvm-mon
Exception in thread "main" java.lang.ExceptionInInitializerError
Caused by: java.lang.IllegalStateException: J2V8 native library not loaded
	at com.eclipsesource.v8.V8.checkNativeLibraryLoaded(V8.java:195)
	at com.eclipsesource.v8.V8.createV8Runtime(V8.java:149)
	at com.eclipsesource.v8.V8.createV8Runtime(V8.java:125)
	at com.eclipsesource.v8.NodeJS.createNodeJS(NodeJS.java:58)
	at com.eclipsesource.v8.NodeJS.createNodeJS(NodeJS.java:45)
	at JvmMon.<clinit>(JvmMon.java:18)
Caused by: java.lang.UnsatisfiedLinkError: Could not load J2V8 library. Reasons: 
	no j2v8_macosx_x86_64 in java.library.path

	at com.eclipsesource.v8.LibraryLoader.loadLibrary(LibraryLoader.java:75)
	at com.eclipsesource.v8.V8.load(V8.java:71)
	at com.eclipsesource.v8.V8.createV8Runtime(V8.java:145)
	... 4 more
Error: jvm-mon: failed

@ajermakovics
Copy link
Contributor Author

@fxcoudert Fixed

@fxcoudert fxcoudert merged commit 8e5250d into Homebrew:master Mar 30, 2017
@fxcoudert
Copy link
Member

Thanks @ajermakovics for your contribution to Homebrew!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bfontaine bfontaine bfontaine approved these changes

@fxcoudert fxcoudert fxcoudert approved these changes

Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajermakovics @fxcoudert @bfontaine