Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detekt 1.22.0: Add --add-opens java.base/java.lang=ALL-UNNAMED for openjdk@17 #116785

Closed
wants to merge 3 commits into from
Closed

detekt 1.22.0: Add --add-opens java.base/java.lang=ALL-UNNAMED for openjdk@17 #116785

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7de4d74
[FIX] Detekt Add --add-opens java.base/java.lang=ALL-UNNAMED
Nov 27, 2022
3c32d40
Review: Add link to detekt issue to remove workaround
Nov 28, 2022
c78cb0c
Review: reminder to remove workaround after root cause is fixed
Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Formula/detekt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ class Detekt < Formula

def install
libexec.install "detekt-cli-#{version}-all.jar"
bin.write_jar_script libexec/"detekt-cli-#{version}-all.jar", "detekt", java_version: "17"
# remove `--add-opens` after https://github.com/detekt/detekt/issues/5576
bin.write_jar_script libexec/"detekt-cli-#{version}-all.jar", "detekt", "--add-opens java.base/java.lang=ALL-UNNAMED", java_version: "17"
rowi1de marked this conversation as resolved.
Show resolved Hide resolved
end

test do
Expand Down