Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.66.0 #118242

Closed
wants to merge 1 commit into from
Closed

rust 1.66.0 #118242

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Dec 15, 2022

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Needs CI-long-timeout labels Dec 15, 2022
@chenrui333 chenrui333 mentioned this pull request Dec 16, 2022
@p-linnane p-linnane added the CI-long-timeout Use longer GitHub Actions CI timeout. label Dec 17, 2022
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 17, 2022
@chenrui333
Copy link
Member Author

linux build looks good 👍

@fxcoudert fxcoudert removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Dec 18, 2022
@chenrui333 chenrui333 mentioned this pull request Dec 20, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Dec 21, 2022
@cho-m cho-m removed the stale No recent activity label Dec 21, 2022
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Dec 21, 2022
@cho-m cho-m added the CI-long-timeout Use longer GitHub Actions CI timeout. label Dec 24, 2022
@cho-m
Copy link
Member

cho-m commented Dec 24, 2022

ARM failures

Rust failures

Python poetry-backend failures

Other failures

@cho-m
Copy link
Member

cho-m commented Dec 25, 2022

Intel-only failures (to be updated)

Ventura

  • sslyze - some linking failure to OpenSSL
  • watchman - probably the same SIMD difference when building bottle vs build-from-source

@chenrui333
Copy link
Member Author

chenrui333 commented Dec 26, 2022

I just tested gnirehtet is indeed broken with the functionality for 13-arm

$ /opt/homebrew/Cellar/gnirehtet/2.5_1/bin/gnirehtet relay -p 8000
2022-12-25 20:52:43.547 INFO Main: Starting relay server on port 8000...
2022-12-25 20:52:43.548 ERROR Main: Execution error: IO error: Address family not supported by protocol family (os error 47)

@chenrui333 chenrui333 closed this Dec 26, 2022
@chenrui333 chenrui333 reopened this Dec 26, 2022
@chenrui333
Copy link
Member Author

accidentally clicked the close button.

@chenrui333 chenrui333 removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Dec 26, 2022
@chenrui333
Copy link
Member Author

@chenrui333
Copy link
Member Author

chenrui333 commented Dec 26, 2022

Most of the issues have been addressed, I think we can skip the dependants and quickly get this PR merged. (will address the intel-only failures separately)

@chenrui333 chenrui333 removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Dec 27, 2022
@chenrui333 chenrui333 added long build Needs CI-long-timeout CI-long-timeout Use longer GitHub Actions CI timeout. labels Dec 27, 2022
@cho-m cho-m removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Dec 28, 2022
@BrewTestBot BrewTestBot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Dec 28, 2022
@chenrui333
Copy link
Member Author

rebased for the brew style syntax fixes.

@chenrui333 chenrui333 added CI-long-timeout Use longer GitHub Actions CI timeout. and removed CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Dec 28, 2022
rust: bump resources
Signed-off-by: Rui Chen <rui@chenrui.dev>
@BrewTestBot BrewTestBot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Dec 28, 2022
@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue and removed CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. in progress Stale bot should stay away labels Dec 28, 2022
@cho-m cho-m removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Dec 28, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@chenrui333 chenrui333 deleted the bump-rust-1.66.0 branch December 28, 2022 16:00
@chenrui333
Copy link
Member Author

chenrui333 commented Dec 29, 2022

sslyze audit check passed on intel runner (macos-12), bash-3.2$ brew audit --strict sslyze

@chenrui333
Copy link
Member Author

watchman install/test/audit also passed on intel runner (macos-12), bash-3.2$ brew audit --strict watchman

But I did observe watchman needs python@3.11, while sslyze needs python@3.10

@chenrui333
Copy link
Member Author

regression test on lexicon also passed on intel macos-12 runner

==> Installing lexicon
==> Pouring lexicon--3.11.7.monterey.bottle.1.tar.gz
🍺  /usr/local/Cellar/lexicon/3.11.7: 6,335 files, 120.5MB

==> Testing lexicon
==> /usr/local/Cellar/lexicon/3.11.7/bin/lexicon route53 list brew.sh TXT 2>&1
==> /usr/local/Cellar/lexicon/3.11.7/bin/lexicon cloudflare create domain.net TXT --name foo --content bar 2>&1
==> /usr/local/Cellar/lexicon/3.11.7/bin/lexicon --version

@chenrui333
Copy link
Member Author

🎉

@cho-m
Copy link
Member

cho-m commented Dec 29, 2022

watchman install/test/audit also passed on intel runner (macos-12), bash-3.2$ brew audit --strict watchman

I think watchman failure happens on brew install --build-from-source ... based on CPU intrinsics. I haven't been able to reproduce via Rosetta which could be due to lack of AVX support.

As I recall, brew install --build-from-source has no -march=... on macOS (it uses -march=native on Linux) while brew install --build-bottle has -march=nehalem. It is possible we need some extra logic like:

if !build.bottle? && Tab.for_formula(Formula["folly"]).built_as_bottle && Hardware::CPU.intel?
  ENV["HOMEBREW_OPTFLAGS"] = "-march=#{Hardware.oldest_cpu}"
end

But have no easy way to test this right now and cannot tell if this even works. Trying to directly pass in -march to C*FLAGS will get removed by superenv.

@EricFromCanada
Copy link
Member

Security alert: v1.66.1 is out.

@ZhongRuoyu ZhongRuoyu mentioned this pull request Jan 29, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
@chenrui333 chenrui333 added the python Python use is a significant feature of the PR or issue label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue long build Needs CI-long-timeout outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.11-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants