libtecla: test added

[lordqwerty]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[fxcoudert]

Thanks for your contribution! The test is a very good idea.

[fxcoudert]

ENV.deparallelize was already present, and making it into a block is a no-op.

[fxcoudert]

This is a traditional configure, the options need to be of the form --prefix

[fxcoudert]

stdio.h and string.h should not be necessary

[fxcoudert]

Thanks, can you squash the commits into one, with commit message libtecla: add test

[maxim-belkin]

what value is gl assigned to in case of a failure? can you add something similar to lines 35-36 above?

[fxcoudert]

It always returns NULL, says the doc.

[lordqwerty]

I don't think this matters. 35 - 36 cover failure enough for test. Line 38 deleting as not doing anything of significance.

[maxim-belkin]

then just don't assign this to gl

[fxcoudert]

It's fine…

[lordqwerty]

I've done something horribly wrong... gulp

[fxcoudert]

You have picked up an unrelated commit.

[lordqwerty]

Sorry for the trouble.

[maxim-belkin]

How about making this a tad more compact?

  test do
    (testpath/"test.c").write <<-EOS.undent
      #include <locale.h>
      #include <libtecla.h>

      int main(int argc, char *argv[]) {
        GetLine *gl;
        setlocale(LC_CTYPE, "");
        gl = new_GetLine(1024, 2048);
        if (!gl) return 1;
        return 0;
      }
    EOS

    system ENV.cc, "test.c", "-L#{lib}", "-ltecla", "-o", "test"
    system "./test"
  end

[lordqwerty]

Please let me know if you would like further changes. If not I believe ready to merge.

[maxim-belkin]

I think it is worth combining lines 28 and 30

[fxcoudert]

Thanks @lordqwerty for your contribution!