Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new blitz repository for head #12014

Merged
merged 2 commits into from Apr 23, 2017
Merged

new blitz repository for head #12014

merged 2 commits into from Apr 23, 2017

Conversation

bhelenbr
Copy link
Contributor

@bhelenbr bhelenbr commented Apr 4, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

blitz has moved to a git repository which is more up to date than the mercurial repository. I have only changed the repository name and removed the requirement for hg

@fxcoudert
Copy link
Member

Is it really the same project? Because the one on github seems to have a 1.0 release which is not the case of the sourceforge project. (And the Github repo is nowhere mentioned on the SF website.)

@bhelenbr
Copy link
Contributor Author

bhelenbr commented Apr 4, 2017 via email

Formula/blitz.rb Outdated
@@ -13,7 +13,7 @@ class Blitz < Formula
end

head do
url "http://blitz.hg.sourceforge.net:8000/hgroot/blitz/blitz", :using => :hg
url "https://github.com/blitzpp/blitz.git", :using => :git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the , :using => :git; it’s the default.

@fxcoudert fxcoudert merged commit a6bcf8a into Homebrew:master Apr 23, 2017
@fxcoudert
Copy link
Member

Thanks @bhelenbr for the pull request!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants