Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echidna 2.0.5 #121092

Closed
wants to merge 1 commit into from
Closed

Conversation

elopez
Copy link
Contributor

@elopez elopez commented Jan 20, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the haskell Haskell use is a significant feature of the PR or issue label Jan 20, 2023
@elopez
Copy link
Contributor Author

elopez commented Jan 20, 2023

As a sidenote, I noticed the 13-arm64 builders do not appear to have Rosetta set up, so they end up skipping bottle production (one of the dependencies on the chain, solc-select, requires it when running on ARM)

@SMillerDev
Copy link
Member

None of the runners should be using rosetta to build anything.

@elopez
Copy link
Contributor Author

elopez commented Jan 20, 2023

It's not used in the build process, but part of the test involves invoking an intel-only program (solc). Normally this works fine because Rosetta is there to help.

I don't know what the right way to proceed here would be, maybe we should skip testing on ARM? This appears to affect only macOS 13 runners FWIW (see the warning about "brew test --verbose echidna failed on macOS Ventura (13) on Apple Silicon!")

@elopez elopez marked this pull request as ready for review January 20, 2023 17:02
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
haskell Haskell use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants