clang-build-analyzer 1.4.0 (new formula)

[ktf]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[SMillerDev]

  ==> Testing clang-build-analyzer
  ==> c++ -c -ftime-trace /tmp/clang-build-analyzer-test-20230123-5633-12u1prm/test.cxx
  c++: error: unrecognized command-line option ‘-ftime-trace’

[ktf]

‘-ftime-trace’ is there only for clang. I made the recipe macOS only.

[ktf]

Now it passes all the tests.

[carlocab]

Why aren't we using an install target?

[ktf]

Fixed

[ktf]

Thank you for your review and changes. There was no particular reason for doing things as they were done, just inexperience with brew Formulas. I have applied all the suggested changes and squashed everything again in one single commit.

[ktf]

All the tests green again.

[carlocab]

This does not seem accurate since the source includes third-party sources with different licenses.

[ktf]

What should I do in that case? Have all the licenses as a list?

[carlocab]

Yes. You can use the all_of: syntax to specify an array of licenses.

[carlocab]

LGTM. Thanks!

[ktf]

Thank you for the detailed review.

[BrewTestBot]

@chenrui333 has triggered a merge.

[chenrui333]

@ktf, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!