qt: add qtversion.xml and caveats. #124923
Conversation
BrewTestBot
added
nodejs
MikeMcQuaid
force-pushed
the
qtversion_xml
branch
from
9acdff3
to
646a44f
Compare
MikeMcQuaid
force-pushed
the
qtversion_xml
branch
from
646a44f
to
c88fa58
Compare
| qtversion_xml = share/"qtcreator/QtProject/qtcreator/qtversion.xml" | ||
| qtversion_xml.dirname.mkpath | ||
| qtversion_xml.write <<~XML | ||
| <?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Other examples online:
- https://github.com/ricardodovalle/config-qtcreator/blob/master/qtcreator/qtversion.xml
- https://github.com/qt-creator/qt-creator/blob/master/tests/system/settings/unix/QtProject/qtcreator/qtversion.xml
I stole this from the locally generated version
| <valuemap type="QVariantMap"> | ||
| <value type="int" key="Id">1</value> | ||
| <value type="QString" key="Name">Qt %{Qt:Version} (Homebrew)</value> | ||
| <value type="QString" key="QMakePath">#{opt_bin}/qmake</value> |
There was a problem hiding this comment.
opt_bin is important here so it persists upgrades
There was a problem hiding this comment.
I'm happy with doing this in principle, but have no idea how to tell if this works. But CC @paperchalice who might know something about this.
MikeMcQuaid
force-pushed
the
qtversion_xml
branch
from
c88fa58
to
b54aaeb
Compare
@carlocab I've tested this locally (I made it to scratch my own itch) and it works well.
@SMillerDev Done, thanks! |
MikeMcQuaid
force-pushed
the
qtversion_xml
branch
from
b54aaeb
to
be6321b
Compare
|
No space left on device: |
|
Yea, needs the self-hosted runner. But that also fails with the same error because it needs to be recreated, and our recreation workflow is broken ATM. |
|
@Bo98 How long would it take to move our Linux creation workflow over to Orchestrator? If not too long: that'd be a great thing to be able to prioritise 🙇🏻 |
|
One thing we could also consider doing is migrating our self-hosted runner workflow to using a GitHub large runner instead. Not sure how the costs compare, but presumably it shouldn't be too different. |
|
We should definitely do this. I'm much less concerned about costs than reliability and removing our need to maintain infrastructure. |
|
If you set up a large GitHub runner (maybe called |
|
@carlocab Done! Have made it as large as we can. That may be excessive but worth it for a trial run I think. |
See discussion at Homebrew#124923.
|
Testing this out at #125189. |
I can prioritise it this weekend. Though a quicker fix is to just revert what broke the workflow. |
Difference being GitHub large runners have a maximum 6 hour limit. It's why we figured it out it's only a replacement for the "need more storage" case, e.g. bottle uploads. |
I'm fine with that. I personally have no idea what broke this. It sounded like from what @p-linnane said that this maybe wasn't a change on our side but on Google's?
I think we need to move away from needing these absurdly long timeouts. A relatively short-term fix here is moving the test formula/test dependents steps into separate dependent jobs rather than separate steps. |
|
It seems a few people want this: - https://stackoverflow.com/questions/68278937/adding-a-homebrew-installed-qt-to-qt-creator-on-a-mac-missing-examples-and-mor - https://stackoverflow.com/questions/53683242/adding-a-homebrew-installed-qt-to-qt-creator-on-a-mac Without this file, it's a bit of a pain to manually enter these settings and QtCreator will resolve the `/opt/homebrew` symlink at choose time so get broken by `brew upgrade`s of Qt.
MikeMcQuaid
force-pushed
the
qtversion_xml
branch
from
be6321b
to
dfd7a66
Compare
|
Reverting the upgrade to the |
|
I've manually run the self-hosted recreation job now that #125210 is merged and it completed successfully. |
|
🤖 A scheduled task has triggered a merge. |
|
Thanks @carlocab and everyone else who helped get this over the line! |
See Homebrew#124923. Qt 5.x also need it.
It seems a few people want this:
Without this file, it's a bit of a pain to manually enter these settings and QtCreator will resolve the
/opt/homebrewsymlink at choose time so get broken bybrew upgrades of Qt.